fix: simplify REST client configuration by preserving BaseURL and UploadURL in WithAuthToken

nickytonline · nickytonline · commit 6b3f5181b6db · 2025-10-04T14:17:07.000-04:00
diff --git a/internal/ghmcp/server.go b/internal/ghmcp/server.go
@@ -199,8 +199,7 @@ func (f *gitHubClientFactory) getRESTClient(ctx context.Context) (*gogithub.Clie
 	baseClient.UploadURL = f.apiHost.uploadURL
 	baseClient.UserAgent = f.currentUserAgent()
 	client := baseClient.WithAuthToken(token)
-	client.BaseURL = f.apiHost.baseRESTURL
-	client.UploadURL = f.apiHost.uploadURL
+	// WithAuthToken does a shallow copy, preserving BaseURL and UploadURL
 	return client, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -199,8 +199,7 @@ func (f gitHubClientFactory) getRESTClient(ctx context.Context) (gogithub.Clie`
`199`	`199`	`baseClient.UploadURL = f.apiHost.uploadURL`
`200`	`200`	`baseClient.UserAgent = f.currentUserAgent()`
`201`	`201`	`client := baseClient.WithAuthToken(token)`
`202`		`- client.BaseURL = f.apiHost.baseRESTURL`
`203`		`- client.UploadURL = f.apiHost.uploadURL`
	`202`	`+ // WithAuthToken does a shallow copy, preserving BaseURL and UploadURL`
`204`	`203`	`return client, nil`
`205`	`204`	`}`
`206`	`205`