Skip to content

Commit 1ce5f1d

Browse files
authored
Merge branch 'ggml-org:master' into mradermacher
2 parents d3cb77a + 34fcc5a commit 1ce5f1d

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+1658
-348
lines changed

.devops/intel.Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
ARG ONEAPI_VERSION=2025.1.1-0-devel-ubuntu24.04
1+
ARG ONEAPI_VERSION=2025.2.2-0-devel-ubuntu24.04
22

33
## Build Image
44

5-
FROM intel/oneapi-basekit:$ONEAPI_VERSION AS build
5+
FROM intel/deep-learning-essentials:$ONEAPI_VERSION AS build
66

77
ARG GGML_SYCL_F16=OFF
88
RUN apt-get update && \
@@ -31,7 +31,7 @@ RUN mkdir -p /app/full \
3131
&& cp requirements.txt /app/full \
3232
&& cp .devops/tools.sh /app/full/tools.sh
3333

34-
FROM intel/oneapi-basekit:$ONEAPI_VERSION AS base
34+
FROM intel/deep-learning-essentials:$ONEAPI_VERSION AS base
3535

3636
RUN apt-get update \
3737
&& apt-get install -y libgomp1 curl\

.devops/rocm.Dockerfile

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
ARG UBUNTU_VERSION=24.04
22

33
# This needs to generally match the container host's environment.
4-
ARG ROCM_VERSION=6.4
5-
ARG AMDGPU_VERSION=6.4
4+
ARG ROCM_VERSION=7.0
5+
ARG AMDGPU_VERSION=7.0
66

77
# Target the ROCm build image
88
ARG BASE_ROCM_DEV_CONTAINER=rocm/dev-ubuntu-${UBUNTU_VERSION}:${ROCM_VERSION}-complete
@@ -13,9 +13,8 @@ FROM ${BASE_ROCM_DEV_CONTAINER} AS build
1313
# Unless otherwise specified, we make a fat build.
1414
# List from https://github.com/ggml-org/llama.cpp/pull/1087#issuecomment-1682807878
1515
# This is mostly tied to rocBLAS supported archs.
16-
# gfx803, gfx900, gfx1032, gfx1101, gfx1102,not officialy supported
17-
# gfx906 is deprecated
18-
#check https://rocm.docs.amd.com/projects/install-on-linux/en/docs-6.4.1/reference/system-requirements.html
16+
# gfx803, gfx900, gfx906, gfx1032, gfx1101, gfx1102,not officialy supported
17+
# check https://rocm.docs.amd.com/projects/install-on-linux/en/docs-6.4.1/reference/system-requirements.html
1918

2019
ARG ROCM_DOCKER_ARCH='gfx803;gfx900;gfx906;gfx908;gfx90a;gfx942;gfx1010;gfx1030;gfx1032;gfx1100;gfx1101;gfx1102;gfx1200;gfx1201;gfx1151'
2120
#ARG ROCM_DOCKER_ARCH='gfx1151'
@@ -36,13 +35,10 @@ WORKDIR /app
3635

3736
COPY . .
3837

39-
RUN git clone https://github.com/rocm/rocwmma --branch develop --depth 1
40-
4138
RUN HIPCXX="$(hipconfig -l)/clang" HIP_PATH="$(hipconfig -R)" \
4239
cmake -S . -B build \
4340
-DGGML_HIP=ON \
4441
-DGGML_HIP_ROCWMMA_FATTN=ON \
45-
-DCMAKE_HIP_FLAGS="-I$(pwd)/rocwmma/library/include/" \
4642
-DAMDGPU_TARGETS="$ROCM_DOCKER_ARCH" \
4743
-DGGML_BACKEND_DL=ON -DGGML_CPU_ALL_VARIANTS=ON \
4844
-DCMAKE_BUILD_TYPE=Release -DLLAMA_BUILD_TESTS=OFF \

.github/workflows/build.yml

Lines changed: 41 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -362,11 +362,11 @@ jobs:
362362
id: checkout
363363
uses: actions/checkout@v4
364364

365-
- name: ccache
366-
uses: ggml-org/[email protected]
367-
with:
368-
key: ubuntu-latest-cmake-rpc
369-
evict-old-files: 1d
365+
# - name: ccache
366+
# uses: ggml-org/[email protected]
367+
# with:
368+
# key: ubuntu-latest-cmake-rpc
369+
# evict-old-files: 1d
370370

371371
- name: Dependencies
372372
id: depends
@@ -387,8 +387,8 @@ jobs:
387387
cd build
388388
ctest -L main --verbose
389389
390-
ubuntu-22-cmake-vulkan:
391-
runs-on: ubuntu-22.04
390+
ubuntu-24-cmake-vulkan:
391+
runs-on: ubuntu-24.04
392392

393393
steps:
394394
- name: Clone
@@ -398,20 +398,40 @@ jobs:
398398
- name: ccache
399399
uses: ggml-org/[email protected]
400400
with:
401-
key: ubuntu-22-cmake-vulkan
401+
key: ubuntu-24-cmake-vulkan
402402
evict-old-files: 1d
403403

404404
- name: Dependencies
405405
id: depends
406406
run: |
407-
wget -qO - https://packages.lunarg.com/lunarg-signing-key-pub.asc | sudo apt-key add -
408-
sudo wget -qO /etc/apt/sources.list.d/lunarg-vulkan-jammy.list https://packages.lunarg.com/vulkan/lunarg-vulkan-jammy.list
407+
sudo add-apt-repository -y ppa:kisak/kisak-mesa
409408
sudo apt-get update -y
410-
sudo apt-get install -y build-essential mesa-vulkan-drivers vulkan-sdk libcurl4-openssl-dev
409+
sudo apt-get install -y build-essential mesa-vulkan-drivers libxcb-xinput0 libxcb-xinerama0 libxcb-cursor-dev libcurl4-openssl-dev
410+
411+
- name: Get latest Vulkan SDK version
412+
id: vulkan_sdk_version
413+
run: |
414+
echo "VULKAN_SDK_VERSION=$(curl https://vulkan.lunarg.com/sdk/latest/linux.txt)" >> "$GITHUB_ENV"
415+
416+
- name: Cache Vulkan SDK
417+
id: cache_vulkan_sdk
418+
uses: actions/cache@v4
419+
with:
420+
path: ./vulkan_sdk
421+
key: vulkan-sdk-${{ env.VULKAN_SDK_VERSION }}-${{ runner.os }}
422+
423+
- name: Install Vulkan SDK
424+
if: steps.cache_vulkan_sdk.outputs.cache-hit != 'true'
425+
id: vulkan_sdk_install
426+
run: |
427+
mkdir -p vulkan_sdk
428+
cd vulkan_sdk
429+
curl --no-progress-meter https://sdk.lunarg.com/sdk/download/latest/linux/vulkan_sdk.tar.xz | tar -Jx --strip-components=1
411430
412431
- name: Build
413432
id: cmake_build
414433
run: |
434+
source ./vulkan_sdk/setup-env.sh
415435
cmake -B build \
416436
-DGGML_VULKAN=ON
417437
cmake --build build --config Release -j $(nproc)
@@ -421,6 +441,7 @@ jobs:
421441
run: |
422442
cd build
423443
export GGML_VK_VISIBLE_DEVICES=0
444+
export GGML_VK_DISABLE_F16=1
424445
# This is using llvmpipe and runs slower than other backends
425446
ctest -L main --verbose --timeout 4200
426447
@@ -487,7 +508,7 @@ jobs:
487508
id: depends
488509
run: |
489510
sudo apt-get update
490-
sudo apt-get install -y build-essential git cmake rocblas-dev hipblas-dev libcurl4-openssl-dev
511+
sudo apt-get install -y build-essential git cmake rocblas-dev hipblas-dev libcurl4-openssl-dev rocwmma-dev
491512
492513
- name: ccache
493514
uses: ggml-org/[email protected]
@@ -1059,7 +1080,7 @@ jobs:
10591080
shell: bash
10601081

10611082
env:
1062-
WINDOWS_BASEKIT_URL: https://registrationcenter-download.intel.com/akdlm/IRC_NAS/7cd9bba0-7aab-4e30-b3ae-2221006a4a05/intel-oneapi-base-toolkit-2025.1.1.34_offline.exe
1083+
WINDOWS_BASEKIT_URL: https://registrationcenter-download.intel.com/akdlm/IRC_NAS/24751ead-ddc5-4479-b9e6-f9fe2ff8b9f2/intel-deep-learning-essentials-2025.2.1.25_offline.exe
10631084
WINDOWS_DPCPP_MKL: intel.oneapi.win.cpp-dpcpp-common:intel.oneapi.win.mkl.devel:intel.oneapi.win.dnnl:intel.oneapi.win.tbb.devel
10641085
ONEAPI_ROOT: "C:/Program Files (x86)/Intel/oneAPI"
10651086
steps:
@@ -1097,10 +1118,12 @@ jobs:
10971118
id: checkout
10981119
uses: actions/checkout@v4
10991120

1100-
- name: Clone rocWMMA repository
1101-
id: clone_rocwmma
1121+
- name: Grab rocWMMA package
1122+
id: grab_rocwmma
11021123
run: |
1103-
git clone https://github.com/rocm/rocwmma --branch rocm-${{ env.ROCM_VERSION }} --depth 1
1124+
curl -o rocwmma.deb "https://repo.radeon.com/rocm/apt/${{ env.ROCM_VERSION }}/pool/main/r/rocwmma-dev/rocwmma-dev_1.7.0.60402-120~24.04_amd64.deb"
1125+
7z x rocwmma.deb
1126+
7z x data.tar
11041127
11051128
- name: Cache ROCm Installation
11061129
id: cache-rocm
@@ -1161,8 +1184,9 @@ jobs:
11611184
cmake -G "Unix Makefiles" -B build -S . `
11621185
-DCMAKE_C_COMPILER="${env:HIP_PATH}\bin\clang.exe" `
11631186
-DCMAKE_CXX_COMPILER="${env:HIP_PATH}\bin\clang++.exe" `
1164-
-DCMAKE_CXX_FLAGS="-I$($PWD.Path.Replace('\', '/'))/rocwmma/library/include/" `
1187+
-DCMAKE_CXX_FLAGS="-I$($PWD.Path.Replace('\', '/'))/opt/rocm-${{ env.ROCM_VERSION }}/include/" `
11651188
-DCMAKE_BUILD_TYPE=Release `
1189+
-DROCM_DIR="${env:HIP_PATH}" `
11661190
-DGGML_HIP=ON `
11671191
-DGGML_HIP_ROCWMMA_FATTN=ON `
11681192
-DGGML_RPC=ON `

.github/workflows/release.yml

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@ jobs:
462462
shell: bash
463463

464464
env:
465-
WINDOWS_BASEKIT_URL: https://registrationcenter-download.intel.com/akdlm/IRC_NAS/7cd9bba0-7aab-4e30-b3ae-2221006a4a05/intel-oneapi-base-toolkit-2025.1.1.34_offline.exe
465+
WINDOWS_BASEKIT_URL: https://registrationcenter-download.intel.com/akdlm/IRC_NAS/24751ead-ddc5-4479-b9e6-f9fe2ff8b9f2/intel-deep-learning-essentials-2025.2.1.25_offline.exe
466466
WINDOWS_DPCPP_MKL: intel.oneapi.win.cpp-dpcpp-common:intel.oneapi.win.mkl.devel:intel.oneapi.win.dnnl:intel.oneapi.win.tbb.devel
467467
ONEAPI_ROOT: "C:/Program Files (x86)/Intel/oneAPI"
468468

@@ -505,6 +505,7 @@ jobs:
505505
cp "${{ env.ONEAPI_ROOT }}/mkl/latest/bin/mkl_tbb_thread.2.dll" ./build/bin
506506
507507
cp "${{ env.ONEAPI_ROOT }}/compiler/latest/bin/ur_adapter_level_zero.dll" ./build/bin
508+
cp "${{ env.ONEAPI_ROOT }}/compiler/latest/bin/ur_adapter_level_zero_v2.dll" ./build/bin
508509
cp "${{ env.ONEAPI_ROOT }}/compiler/latest/bin/ur_adapter_opencl.dll" ./build/bin
509510
cp "${{ env.ONEAPI_ROOT }}/compiler/latest/bin/ur_loader.dll" ./build/bin
510511
cp "${{ env.ONEAPI_ROOT }}/compiler/latest/bin/ur_win_proxy_loader.dll" ./build/bin
@@ -513,10 +514,15 @@ jobs:
513514
cp "${{ env.ONEAPI_ROOT }}/compiler/latest/bin/svml_dispmd.dll" ./build/bin
514515
cp "${{ env.ONEAPI_ROOT }}/compiler/latest/bin/libmmd.dll" ./build/bin
515516
cp "${{ env.ONEAPI_ROOT }}/compiler/latest/bin/libiomp5md.dll" ./build/bin
517+
cp "${{ env.ONEAPI_ROOT }}/compiler/latest/bin/sycl-ls.exe" ./build/bin
516518
517519
cp "${{ env.ONEAPI_ROOT }}/dnnl/latest/bin/dnnl.dll" ./build/bin
518520
cp "${{ env.ONEAPI_ROOT }}/tbb/latest/bin/tbb12.dll" ./build/bin
519521
522+
cp "${{ env.ONEAPI_ROOT }}/tcm/latest/bin/tcm.dll" ./build/bin
523+
cp "${{ env.ONEAPI_ROOT }}/tcm/latest/bin/libhwloc-15.dll" ./build/bin
524+
cp "${{ env.ONEAPI_ROOT }}/umf/latest/bin/umf.dll" ./build/bin
525+
520526
echo "cp oneAPI running time dll files to ./build/bin done"
521527
7z a llama-bin-win-sycl-x64.zip ./build/bin/*
522528
@@ -543,10 +549,12 @@ jobs:
543549
id: checkout
544550
uses: actions/checkout@v4
545551

546-
- name: Clone rocWMMA repository
547-
id: clone_rocwmma
552+
- name: Grab rocWMMA package
553+
id: grab_rocwmma
548554
run: |
549-
git clone https://github.com/rocm/rocwmma --branch develop --depth 1
555+
curl -o rocwmma.deb "https://repo.radeon.com/rocm/apt/7.0.1/pool/main/r/rocwmma-dev/rocwmma-dev_2.0.0.70001-42~24.04_amd64.deb"
556+
7z x rocwmma.deb
557+
7z x data.tar
550558
551559
- name: Cache ROCm Installation
552560
id: cache-rocm
@@ -601,7 +609,7 @@ jobs:
601609
cmake -G "Unix Makefiles" -B build -S . `
602610
-DCMAKE_C_COMPILER="${env:HIP_PATH}\bin\clang.exe" `
603611
-DCMAKE_CXX_COMPILER="${env:HIP_PATH}\bin\clang++.exe" `
604-
-DCMAKE_CXX_FLAGS="-I$($PWD.Path.Replace('\', '/'))/rocwmma/library/include/ -Wno-ignored-attributes -Wno-nested-anon-types" `
612+
-DCMAKE_CXX_FLAGS="-I$($PWD.Path.Replace('\', '/'))/opt/rocm-7.0.1/include/ -Wno-ignored-attributes -Wno-nested-anon-types" `
605613
-DCMAKE_BUILD_TYPE=Release `
606614
-DGGML_BACKEND_DL=ON `
607615
-DGGML_NATIVE=OFF `

CODEOWNERS

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
/common/build-info.* @ggerganov
1515
/common/common.* @ggerganov
1616
/common/console.* @ggerganov
17+
/common/http.* @angt
1718
/common/llguidance.* @ggerganov
1819
/common/log.* @ggerganov
1920
/common/sampling.* @ggerganov
@@ -58,6 +59,9 @@
5859
/ggml/src/ggml-cuda/mmq.* @JohannesGaessler
5960
/ggml/src/ggml-cuda/mmvf.* @JohannesGaessler
6061
/ggml/src/ggml-cuda/mmvq.* @JohannesGaessler
62+
/ggml/src/ggml-cuda/fattn-wmma* @IMbackK
63+
/ggml/src/ggml-hip/ @IMbackK
64+
/ggml/src/ggml-cuda/vendors/hip.h @IMbackK
6165
/ggml/src/ggml-impl.h @ggerganov @slaren
6266
/ggml/src/ggml-metal/ @ggerganov
6367
/ggml/src/ggml-opencl/ @lhez @max-krasnyansky

ci/run.sh

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@ mkdir -p "$2"
3434
OUT=$(realpath "$1")
3535
MNT=$(realpath "$2")
3636

37-
rm -f "$OUT/*.log"
38-
rm -f "$OUT/*.exit"
39-
rm -f "$OUT/*.md"
37+
rm -f $OUT/*.log
38+
rm -f $OUT/*.exit
39+
rm -f $OUT/*.md
4040

4141
sd=`dirname $0`
4242
cd $sd/../
@@ -607,6 +607,7 @@ if [ -z ${GG_BUILD_LOW_PERF} ]; then
607607
fi
608608

609609
ret=0
610+
610611
test $ret -eq 0 && gg_run ctest_debug
611612
test $ret -eq 0 && gg_run ctest_release
612613

@@ -624,4 +625,6 @@ if [ -z ${GG_BUILD_LOW_PERF} ]; then
624625
test $ret -eq 0 && gg_run ctest_with_model_release
625626
fi
626627

628+
cat $OUT/README.md
629+
627630
exit $ret

common/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ add_library(${TARGET} STATIC
5656
common.h
5757
console.cpp
5858
console.h
59+
http.h
5960
json-partial.cpp
6061
json-partial.h
6162
json-schema-to-grammar.cpp

0 commit comments

Comments
 (0)