python: a bit nicer error on duplicate parametrization

Raising `ValueError` dumps all of the internal stacktrace to the user,
which is not helpful. Raising `CollectError` is handled specially to
just print the message.

It would be nice to show source location or such - maybe another time.

Fix pytest-dev#13457

Author: bluetech

changelog/13457.improvement.rst

@@ -0,0 +1 @@
+The error message about duplicate parametrization no longer displays an internal stack trace.

src/_pytest/python.py

@@ -1079,7 +1079,9 @@ def setmulti(
         arg2scope = dict(self._arg2scope)
         for arg, val in zip(argnames, valset):
             if arg in params:
-                raise ValueError(f"duplicate parametrization of {arg!r}")
+                raise nodes.Collector.CollectError(
+                    f"duplicate parametrization of {arg!r}"
+                )
             params[arg] = val
             indices[arg] = param_index
             arg2scope[arg] = scope

testing/python/metafunc.py

@@ -82,11 +82,15 @@ def func(x, y):
 
         metafunc = self.Metafunc(func)
         metafunc.parametrize("x", [1, 2])
-        pytest.raises(ValueError, lambda: metafunc.parametrize("x", [5, 6]))
-        pytest.raises(ValueError, lambda: metafunc.parametrize("x", [5, 6]))
+        with pytest.raises(pytest.Collector.CollectError):
+            metafunc.parametrize("x", [5, 6])
+        with pytest.raises(pytest.Collector.CollectError):
+            metafunc.parametrize("x", [5, 6])
         metafunc.parametrize("y", [1, 2])
-        pytest.raises(ValueError, lambda: metafunc.parametrize("y", [5, 6]))
-        pytest.raises(ValueError, lambda: metafunc.parametrize("y", [5, 6]))
+        with pytest.raises(pytest.Collector.CollectError):
+            metafunc.parametrize("y", [5, 6])
+        with pytest.raises(pytest.Collector.CollectError):
+            metafunc.parametrize("y", [5, 6])
 
         with pytest.raises(TypeError, match="^ids must be a callable or an iterable$"):
             metafunc.parametrize("y", [5, 6], ids=42)  # type: ignore[arg-type]