Skip to content

Commit 7acf16e

Browse files
committed
bug symfony#27941 [WebProfilerBundle] Fixed icon alignment issue using Bootstrap 4.1.2 (jmsche)
This PR was merged into the 2.8 branch. Discussion ---------- [WebProfilerBundle] Fixed icon alignment issue using Bootstrap 4.1.2 | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes? | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Hi, This PR fixes an issue introduced by Bootstrap 4.1.2: it vertically aligns SVG icons in the middle instead of letting it stay at the baseline. I'm not sure this PR is relevant but, if I'm not the only Bootstrap user, I guess it will be useful to many and it does not break anything: it enforces what should be default. [Update] Here is the related PR merged into Bootstrap that causes the issue: twbs/bootstrap#25874 [Update 2] Before the fix: ![fix_before](https://user-images.githubusercontent.com/3929498/42696806-966cfc9e-86b9-11e8-90a9-7a6dc18a1809.png) After the fix: ![fix_after](https://user-images.githubusercontent.com/3929498/42696821-9df8ef22-86b9-11e8-8c6c-62a4afa752a3.png) Commits ------- ecef6f1 [WebProfilerBundle] Fixed icon alignment issue using Bootstrap 4.1.2
2 parents f803762 + ecef6f1 commit 7acf16e

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar.css.twig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,7 @@ div.sf-toolbar .sf-toolbar-block a:hover {
263263
border-width: 0;
264264
position: relative;
265265
top: 8px;
266+
vertical-align: baseline;
266267
}
267268

268269
.sf-toolbar-block .sf-toolbar-icon img + span,

0 commit comments

Comments
 (0)