Skip to content

Commit f68e194

Browse files
Merge branch '4.0' into 4.1
* 4.0: [Cache] fix Memcached tests
2 parents 34acfe4 + 9b64e8b commit f68e194

File tree

3 files changed

+43
-3
lines changed

3 files changed

+43
-3
lines changed

src/Symfony/Component/Cache/Tests/Adapter/MemcachedAdapterTest.php

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ class MemcachedAdapterTest extends AdapterTestCase
2222
);
2323

2424
protected static $client;
25+
protected static $enableVersioning = false;
2526

2627
public static function setupBeforeClass()
2728
{
@@ -41,7 +42,23 @@ public function createCachePool($defaultLifetime = 0)
4142
{
4243
$client = $defaultLifetime ? AbstractAdapter::createConnection('memcached://'.getenv('MEMCACHED_HOST')) : self::$client;
4344

44-
return new MemcachedAdapter($client, str_replace('\\', '.', __CLASS__), $defaultLifetime);
45+
$adapter = new MemcachedAdapter($client, str_replace('\\', '.', __CLASS__), $defaultLifetime);
46+
47+
if (self::$enableVersioning) {
48+
$adapter->enableVersioning();
49+
}
50+
51+
return $adapter;
52+
}
53+
54+
public function testClear()
55+
{
56+
self::$enableVersioning = true;
57+
try {
58+
parent::testClear();
59+
} finally {
60+
self::$enableVersioning = false;
61+
}
4562
}
4663

4764
public function testOptions()

src/Symfony/Component/Cache/Tests/Simple/MemcachedCacheTest.php

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ class MemcachedCacheTest extends CacheTestCase
2323
);
2424

2525
protected static $client;
26+
protected static $enableVersioning = false;
2627

2728
public static function setupBeforeClass()
2829
{
@@ -42,7 +43,23 @@ public function createSimpleCache($defaultLifetime = 0)
4243
{
4344
$client = $defaultLifetime ? AbstractAdapter::createConnection('memcached://'.getenv('MEMCACHED_HOST'), array('binary_protocol' => false)) : self::$client;
4445

45-
return new MemcachedCache($client, str_replace('\\', '.', __CLASS__), $defaultLifetime);
46+
$adapter = new MemcachedCache($client, str_replace('\\', '.', __CLASS__), $defaultLifetime);
47+
48+
if (self::$enableVersioning) {
49+
$adapter->enableVersioning();
50+
}
51+
52+
return $adapter;
53+
}
54+
55+
public function testClear()
56+
{
57+
self::$enableVersioning = true;
58+
try {
59+
parent::testClear();
60+
} finally {
61+
self::$enableVersioning = false;
62+
}
4663
}
4764

4865
public function testCreatePersistentConnectionShouldNotDupServerList()

src/Symfony/Component/Cache/Tests/Simple/MemcachedCacheTextModeTest.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,12 @@ public function createSimpleCache($defaultLifetime = 0)
2020
{
2121
$client = AbstractAdapter::createConnection('memcached://'.getenv('MEMCACHED_HOST'), array('binary_protocol' => false));
2222

23-
return new MemcachedCache($client, str_replace('\\', '.', __CLASS__), $defaultLifetime);
23+
$adapter = new MemcachedCache($client, str_replace('\\', '.', __CLASS__), $defaultLifetime);
24+
25+
if (self::$enableVersioning) {
26+
$adapter->enableVersioning();
27+
}
28+
29+
return $adapter;
2430
}
2531
}

0 commit comments

Comments
 (0)