Skip to content

Commit fea72fb

Browse files
committed
bug symfony#23829 Fixed the exception page design in responsive mode (javiereguiluz)
This PR was merged into the 3.3 branch. Discussion ---------- Fixed the exception page design in responsive mode | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I broke the design of the exception pages in responsive mode between Symfony 3.3.5 and 3.3.6: ### Symfony 3.3.5 ![sf-335](https://user-images.githubusercontent.com/73419/29074568-127cbf92-7c50-11e7-9e4e-51ad1c61e03c.png) ### Symfony 3.3.6 ![sf-336](https://user-images.githubusercontent.com/73419/29074567-11d38b48-7c50-11e7-9114-036cbe4d07e9.png) --- This PR fixes the issue and also removes some CSS leftovers used during the redesign. Commits ------- cd8af22 Fixed the exception page design in responsive mode
2 parents 0bcc6bb + cd8af22 commit fea72fb

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/Symfony/Bundle/TwigBundle/Resources/views/exception.css.twig

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ header .container { display: flex; justify-content: space-between; }
8080
.exception-hierarchy .icon svg { height: 13px; width: 13px; vertical-align: -2px; }
8181

8282
.exception-without-message .exception-message-wrapper { display: none; }
83-
.exception-message-wrapper .container { display: flex; align-items: flex-start; min-height: 70px; padding: 10px 0 8px; }
83+
.exception-message-wrapper .container { display: flex; align-items: flex-start; min-height: 70px; padding: 10px 15px 8px; }
8484
.exception-message { flex-grow: 1; }
8585
.exception-message, .exception-message a { color: #FFF; font-size: 21px; font-weight: 400; margin: 0; }
8686
.exception-message.long { font-size: 18px; }
@@ -107,11 +107,11 @@ header .container { display: flex; justify-content: space-between; }
107107
.trace-line .icon svg { height: 16px; width: 16px; }
108108
.trace-line-header { padding-left: 36px; }
109109

110-
.trace-file-path, .trace-file-path a { color: #999; color: #795da3; color: #B0413E; color: #222; font-size: 13px; }
110+
.trace-file-path, .trace-file-path a { color: #222; font-size: 13px; }
111111
.trace-class { color: #B0413E; }
112112
.trace-type { padding: 0 2px; }
113-
.trace-method { color: #B0413E; color: #222; font-weight: bold; color: #B0413E; }
114-
.trace-arguments { color: #222; color: #999; font-weight: normal; color: #795da3; color: #777; padding-left: 2px; }
113+
.trace-method { color: #B0413E; font-weight: bold; }
114+
.trace-arguments { color: #777; font-weight: normal; padding-left: 2px; }
115115

116116
.trace-code { background: #FFF; font-size: 12px; margin: 10px 10px 2px 10px; padding: 10px; overflow-x: auto; white-space: nowrap; }
117117
.trace-code ol { margin: 0; float: left; }

src/Symfony/Component/Debug/ExceptionHandler.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -320,11 +320,11 @@ public function getStylesheet(FlattenException $exception)
320320
321321
.trace-message { font-size: 14px; font-weight: normal; margin: .5em 0 0; }
322322
323-
.trace-file-path, .trace-file-path a { margin-top: 3px; color: #999; color: #795da3; color: #B0413E; color: #222; font-size: 13px; }
323+
.trace-file-path, .trace-file-path a { color: #222; margin-top: 3px; font-size: 13px; }
324324
.trace-class { color: #B0413E; }
325325
.trace-type { padding: 0 2px; }
326-
.trace-method { color: #B0413E; color: #222; font-weight: bold; color: #B0413E; }
327-
.trace-arguments { color: #222; color: #999; font-weight: normal; color: #795da3; color: #777; padding-left: 2px; }
326+
.trace-method { color: #B0413E; font-weight: bold; }
327+
.trace-arguments { color: #777; font-weight: normal; padding-left: 2px; }
328328
329329
@media (min-width: 575px) {
330330
.hidden-xs-down { display: initial; }

0 commit comments

Comments
 (0)