fix: find last newsletter publication (#329)

cause issues with missing publications detection

Author: nicopico-dev

server/src/main/kotlin/fr/nicopico/n2rss/newsletter/data/PublicationRepository.kt

@@ -15,7 +15,6 @@
  * CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  * DEALINGS IN THE SOFTWARE.
  */
-
 package fr.nicopico.n2rss.newsletter.data
 
 import fr.nicopico.n2rss.newsletter.data.entity.PublicationEntity
@@ -28,4 +27,5 @@ interface PublicationRepository : JpaRepository<PublicationEntity, UUID> {
     fun findByNewsletterCode(newsletterCode: String, pageable: Pageable): Page<PublicationEntity>
     fun countPublicationsByNewsletterCode(newsletterCode: String): Long
     fun findFirstByNewsletterCodeOrderByDateAsc(newsletterCode: String): PublicationEntity?
+    fun findFirstByNewsletterCodeOrderByDateDesc(newsletterCode: String): PublicationEntity?
 }

server/src/main/kotlin/fr/nicopico/n2rss/newsletter/service/PublicationService.kt

@@ -133,7 +133,7 @@ class PublicationService(
 
     private fun Newsletter.getLastPublicationDate(): LocalDate {
         val lastPublication = requireNotNull(
-            publicationRepository.findByNewsletterCode(code, Pageable.ofSize(1)).first()
+            publicationRepository.findFirstByNewsletterCodeOrderByDateDesc(code)
         ) { "Newsletter must have at least one publication" }
         return lastPublication.date.toKotlinLocaleDate()
     }

server/src/test/kotlin/fr/nicopico/n2rss/newsletter/service/PublicationServiceTest.kt

@@ -184,9 +184,10 @@ class PublicationServiceTest {
         val newsletterCode = "delivering"
         val newsletter = createStubNewsletter(newsletterCode)
         every { publicationRepository.countPublicationsByNewsletterCode(any()) } returns 10L
-        every { publicationRepository.findFirstByNewsletterCodeOrderByDateAsc(any()) } returns createStubPublicationEntity(
-            newsletter
-        )
+        every { publicationRepository.findFirstByNewsletterCodeOrderByDateAsc(any()) } returns
+            createStubPublicationEntity(newsletter)
+        every { publicationRepository.findFirstByNewsletterCodeOrderByDateDesc(any()) } returns
+            createStubPublicationEntity(newsletter)
         every { publicationRepository.findByNewsletterCode(newsletterCode, any()) } returns PageImpl(
             listOf(
                 createStubPublicationEntity(newsletter),
@@ -264,9 +265,10 @@ class PublicationServiceTest {
 
             // Additional stubs required by `stats` computation
             every { publicationRepository.countPublicationsByNewsletterCode(any()) } returns 5L
-            every { publicationRepository.findFirstByNewsletterCodeOrderByDateAsc(any()) } returns createStubPublicationEntity(
-                newsletter
-            )
+            every { publicationRepository.findFirstByNewsletterCodeOrderByDateAsc(any()) } returns
+                createStubPublicationEntity(newsletter)
+            every { publicationRepository.findFirstByNewsletterCodeOrderByDateDesc(any()) } returns
+                createStubPublicationEntity(newsletter)
 
             // WHEN
             val stats = publicationService.getNewsletterStats(newsletter)
@@ -336,9 +338,10 @@ class PublicationServiceTest {
 
             // Additional stubs
             every { publicationRepository.countPublicationsByNewsletterCode(any()) } returns 5L
-            every { publicationRepository.findFirstByNewsletterCodeOrderByDateAsc(any()) } returns createStubPublicationEntity(
-                newsletter
-            )
+            every { publicationRepository.findFirstByNewsletterCodeOrderByDateAsc(any()) } returns
+                createStubPublicationEntity(newsletter)
+            every { publicationRepository.findFirstByNewsletterCodeOrderByDateDesc(any()) } returns
+                createStubPublicationEntity(newsletter)
 
             // WHEN
             val stats = publicationService.getNewsletterStats(newsletter)