Add tests

Author: nielsbauman

server/src/test/java/org/elasticsearch/cluster/metadata/DataStreamLifecycleTemplateTests.java

@@ -226,6 +226,7 @@ public static DataStreamLifecycle.Template randomDataLifecycleTemplate() {
                     ? randomBoolean() ? ResettableValue.undefined() : ResettableValue.reset()
                     : randomDownsamplingMethod()
             )
+            .frozenAfter(randomFrozenAfter())
             .buildTemplate();
     }
 
@@ -295,7 +296,7 @@ private static ResettableValue<TimeValue> randomFrozenAfter() {
         return switch (randomIntBetween(0, 2)) {
             case 0 -> ResettableValue.undefined();
             case 1 -> ResettableValue.reset();
-            case 2 -> ResettableValue.create(TimeValue.timeValueDays(randomIntBetween(1, 100)));
+            case 2 -> ResettableValue.create(randomPositiveTimeValue());
             default -> throw new IllegalStateException("Unknown randomisation path");
         };
     }

server/src/test/java/org/elasticsearch/cluster/metadata/DataStreamLifecycleTests.java

@@ -493,6 +493,15 @@ public void testEffectiveRetention() {
         }
     }
 
+    public void testNegativeFrozenAfter() {
+        final var frozenAfter = randomBoolean() ? TimeValue.ZERO : TimeValue.MINUS_ONE;
+        IllegalArgumentException exception = expectThrows(
+            IllegalArgumentException.class,
+            () -> DataStreamLifecycle.dataLifecycleBuilder().frozenAfter(frozenAfter).build()
+        );
+        assertThat(exception.getMessage(), equalTo("frozen_after must be a positive time value"));
+    }
+
     public void testEffectiveRetentionParams() {
         Map<String, String> initialParams = randomMap(0, 10, () -> Tuple.tuple(randomAlphaOfLength(10), randomAlphaOfLength(10)));
         ToXContent.Params params = DataStreamLifecycle.addEffectiveRetentionParams(new ToXContent.MapParams(initialParams));