Avoid pointless cast to prevent implementation-defined conversion warning

nielsdos · nielsdos · commit ff3e7679b130 · 2024-07-06T13:49:45.000-07:00
diff --git a/ext/xml/xml.c b/ext/xml/xml.c
@@ -523,7 +523,7 @@ static zend_string *xml_utf8_decode(const XML_Char *s, size_t len, const XML_Cha
 			c = '?';
 		}
 
-		ZSTR_VAL(str)[ZSTR_LEN(str)++] = (unsigned int)decoder(c);
+		ZSTR_VAL(str)[ZSTR_LEN(str)++] = decoder(c);
 	}
 	ZSTR_VAL(str)[ZSTR_LEN(str)] = '\0';
 	if (ZSTR_LEN(str) < len) {

Original file line number	Diff line number	Diff line change
`@@ -523,7 +523,7 @@ static zend_string xml_utf8_decode(const XML_Char s, size_t len, const XML_Cha`
`523`	`523`	`c = '?';`
`524`	`524`	`}`
`525`	`525`
`526`		`- ZSTR_VAL(str)[ZSTR_LEN(str)++] = (unsigned int)decoder(c);`
	`526`	`+ ZSTR_VAL(str)[ZSTR_LEN(str)++] = decoder(c);`
`527`	`527`	`}`
`528`	`528`	`ZSTR_VAL(str)[ZSTR_LEN(str)] = '\0';`
`529`	`529`	`if (ZSTR_LEN(str) < len) {`