add binary flag to open files

Dan Hertz · Dan Hertz · commit 2ac21dc2a84d · 2021-12-03T15:36:09.000-08:00
diff --git a/nightfall/api.py b/nightfall/api.py
@@ -187,7 +187,7 @@ def upload_chunk(id, data, headers):
             )
             return response
 
-        with open(location) as fp:
+        with open(location, 'rb') as fp:
             for ix, piece in read_chunks(fp, chunk_size):
                 headers = self._headers
                 headers["X-UPLOAD-OFFSET"] = str(ix * chunk_size)

Original file line number	Diff line number	Diff line change
`@@ -187,7 +187,7 @@ def upload_chunk(id, data, headers):`
`187`	`187`	`)`
`188`	`188`	`return response`
`189`	`189`
`190`		`- with open(location) as fp:`
	`190`	`+ with open(location, 'rb') as fp:`
`191`	`191`	`for ix, piece in read_chunks(fp, chunk_size):`
`192`	`192`	`headers = self._headers`
`193`	`193`	`headers["X-UPLOAD-OFFSET"] = str(ix * chunk_size)`