Skip to content

Commit 602c536

Browse files
author
Dan Hertz
committed
remove java references
1 parent 14ee308 commit 602c536

File tree

6 files changed

+9
-13
lines changed

6 files changed

+9
-13
lines changed

CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
# These owners will be the default owners for everything in
22
# the repo.
3-
* @evanfuller @galennightfall @dhertz
3+
* @evanfuller @austinphilp @smkent @dhertz

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Contributing
22

3-
Thank you for considering contributing to the Nightfall Java SDK.
3+
Thank you for considering contributing to the Nightfall Python SDK.
44

55
There are many ways to contribute, such as:
66
* Writing code samples
@@ -13,15 +13,15 @@ to address those issues.
1313

1414
## Responsibilities
1515
* Ensure cross-platform compatibility for every change that's accepted. Windows, Mac, Debian & Ubuntu Linux, etc.
16-
* Ensure backwards compatibility with Java 8
16+
* Ensure backwards compatibility with Python 3.7+.
1717
* Create issues for each major change and enhancement that you wish to make.
1818
* Discuss proposed changes transparently and collect community feedback.
1919
* Avoid introducing new external dependencies whenever possible. When absolutely required, validate the software
2020
licenses used by these dependencies (e.g. avoid unintentional copyleft requirements).
2121

2222
## How to report a bug
2323

24-
### Security Disclosures
24+
### Security Disclosures
2525
If you find a security vulnerability, do NOT open an issue. Email `[email protected]` instead.
2626

2727
In order to determine whether you are dealing with a security issue, ask yourself the following questions:

README.md

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Nightfall Python SDK
22

3-
**Embed Nightfall scanning and detection functionality into Java applications**
3+
**Embed Nightfall scanning and detection functionality into Python applications**
44

55
[![PyPI version](https://badge.fury.io/py/nightfall.svg)](https://badge.fury.io/py/nightfall)
66

@@ -104,8 +104,8 @@ print("started scan", id, message)
104104
## Contributing
105105

106106
Contributions are welcome! Open a pull request to fix a bug, or open an issue to discuss a new feature
107-
or change. Please adhere to the linting criteria defined in `checkstyle.xml`, and be sure to add unit
108-
tests for any new functionality you add.
107+
or change. Please adhere to the linting criteria expected by flake8, and be sure to add unit tests for
108+
any new functionality you add.
109109

110110
Refer to `CONTRIBUTING.md` for the full details.
111111

@@ -114,9 +114,6 @@ Refer to `CONTRIBUTING.md` for the full details.
114114
This code is licensed under the terms of the MIT License. See [here](https://opensource.org/licenses/MIT)
115115
for more information.
116116

117-
Java is licensed by Oracle. See [here](https://www.oracle.com/java/technologies/javase/jdk-faqs.html)
118-
for more information.
119-
120117
Please create an issue with a description of your problem, or open a pull request with the fix.
121118

122119
## Development

nightfall/api.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ def __init__(self, key: Optional[str] = None, signing_secret: Optional[str] = No
4545

4646
self._headers = {
4747
"Content-Type": "application/json",
48-
"User-Agent": "nightfall-python-sdk/1.0.0",
48+
"User-Agent": "nightfall-python-sdk/1.1.0",
4949
'Authorization': f'Bearer {self.key}',
5050
}
5151
self.signing_secret = signing_secret

nightfall/detection_rules.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@ def as_dict(self):
124124
"charsToIgnore": self.chars_to_ignore
125125
}
126126

127+
127128
@dataclass
128129
class RedactionConfig:
129130
"""An object that configures how any detected findings should be redacted when returned to the client. When this

tests/test_api.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
1-
import datetime
21
import os
3-
import time
42

53
from freezegun import freeze_time
64
import pytest

0 commit comments

Comments
 (0)