Fix default redaction configs (#69)

Author: evanfuller

internal/clients/diffreviewer/circleci/circleci_service.go

@@ -119,6 +119,7 @@ func (s *Service) LoadConfig(nightfallConfigFileName string) (*nightfallconfig.C
 		TokenExclusionList:          nightfallConfig.TokenExclusionList,
 		FileInclusionList:           nightfallConfig.FileInclusionList,
 		FileExclusionList:           nightfallConfig.FileExclusionList,
+		DefaultRedactionConfig:      nightfallConfig.DefaultRedactionConfig,
 	}, nil
 }
 

internal/clients/diffreviewer/circleci/circleci_service_test.go

@@ -213,6 +213,9 @@ func (c *circleCiTestSuite) TestLoadConfig() {
 		TokenExclusionList:         []string{excludedCreditCardRegex, excludedApiToken, excludedIPRegex},
 		FileInclusionList:          []string{"*"},
 		FileExclusionList:          []string{".nightfalldlp/config.json"},
+		DefaultRedactionConfig: &nf.RedactionConfig{
+			SubstitutionConfig: &nf.SubstitutionConfig{SubstitutionPhrase: "REDACTED"},
+		},
 	}
 
 	nightfallConfig, err := tp.cs.LoadConfig(testConfigFileName)
@@ -315,6 +318,12 @@ func (c *circleCiTestSuite) TestLoadEmptyConfig() {
 			},
 		},
 		NightfallMaxNumberRoutines: nightfallconfig.DefaultMaxNumberRoutines,
+		DefaultRedactionConfig: &nf.RedactionConfig{
+			MaskConfig: &nf.MaskConfig{
+				MaskingChar:             "*",
+				NumCharsToLeaveUnmasked: 2,
+			},
+		},
 	}
 
 	nightfallConfig, err := tp.cs.LoadConfig(testEmptyConfigFileName)

internal/clients/diffreviewer/github/github_service.go

@@ -23,10 +23,6 @@ import (
 type Level string
 
 const (
-	InfoLevel    Level = "info"
-	WarningLevel Level = "warning"
-	ErrorLevel   Level = "error"
-
 	WorkspacePathEnvVar      = "GITHUB_WORKSPACE"
 	EventPathEnvVar          = "GITHUB_EVENT_PATH"
 	BaseRefEnvVar            = "GITHUB_BASE_REF"
@@ -207,6 +203,7 @@ func (s *Service) LoadConfig(nightfallConfigFileName string) (*nightfallconfig.C
 		TokenExclusionList:          nightfallConfig.TokenExclusionList,
 		FileInclusionList:           nightfallConfig.FileInclusionList,
 		FileExclusionList:           nightfallConfig.FileExclusionList,
+		DefaultRedactionConfig:      nightfallConfig.DefaultRedactionConfig,
 	}, nil
 }
 

internal/clients/diffreviewer/github/github_service_test.go

@@ -209,6 +209,9 @@ func (g *githubTestSuite) TestLoadConfig() {
 		TokenExclusionList:         []string{excludedCreditCardRegex, excludedApiToken, excludedIPRegex},
 		FileInclusionList:          []string{"*"},
 		FileExclusionList:          []string{".nightfalldlp/config.json"},
+		DefaultRedactionConfig: &nf.RedactionConfig{
+			SubstitutionConfig: &nf.SubstitutionConfig{SubstitutionPhrase: "REDACTED"},
+		},
 	}
 	expectedGithubCheckRequest := &CheckRequest{
 		Owner:       owner,
@@ -304,6 +307,12 @@ func (g *githubTestSuite) TestLoadEmptyConfig() {
 			},
 		},
 		NightfallMaxNumberRoutines: nightfallconfig.DefaultMaxNumberRoutines,
+		DefaultRedactionConfig: &nf.RedactionConfig{
+			MaskConfig: &nf.MaskConfig{
+				MaskingChar:             "*",
+				NumCharsToLeaveUnmasked: 2,
+			},
+		},
 	}
 	expectedGithubCheckRequest := &CheckRequest{
 		Owner:       owner,