WIP

Author: nik9000

benchmarks/README.md

@@ -126,9 +126,12 @@ exit
 Grab the async profiler from https://github.com/jvm-profiling-tools/async-profiler
 and run `prof async` like so:
 ```
-gradlew -p benchmarks/ run --args 'LongKeyedBucketOrdsBenchmark.multiBucket -prof "async:libPath=/home/nik9000/Downloads/tmp/async-profiler-1.8.3-linux-x64/build/libasyncProfiler.so;dir=/tmp/prof;output=flamegraph"'
+gradlew -p benchmarks/ run --args 'LongKeyedBucketOrdsBenchmark.multiBucket -prof "async:libPath=/home/nik9000/Downloads/async-profiler-3.0-29ee888-linux-x64/lib/libasyncProfiler.so;dir=/tmp/prof;output=flamegraph"'
 ```
 
+Note: As of January 2025 the latest release of async profiler doesn't work
+      with out JDK but the nightly is fine.
+
 If you are on Mac, this'll warn you that you downloaded the shared library from
 the internet. You'll need to go to settings and allow it to run.
 

benchmarks/src/main/java/org/elasticsearch/benchmark/compute/operator/EvalBenchmark.java

@@ -97,9 +97,9 @@ public class EvalBenchmark {
             "add_double",
             "case_1_eager",
             "case_1_lazy",
-            "coalesce_1_noop",
-            "coalesce_1_eager",
-            "coalesce_1_lazy",
+            "coalesce_2_noop",
+            "coalesce_2_eager",
+            "coalesce_2_lazy",
             "date_trunc",
             "equal_to_const",
             "long_equal_to_long",
@@ -154,7 +154,7 @@ private static EvalOperator.ExpressionEvaluator evaluator(String operation) {
                 }
                 yield evaluator;
             }
-            case "coalesce_1_noop", "coalesce_1_eager", "coalesce_1_lazy" -> {
+            case "coalesce_2_noop", "coalesce_2_eager", "coalesce_2_lazy" -> {
                 FieldAttribute f1 = longField();
                 FieldAttribute f2 = longField();
                 Expression lhs = f1;
@@ -165,7 +165,7 @@ private static EvalOperator.ExpressionEvaluator evaluator(String operation) {
                     new Coalesce(Source.EMPTY, lhs, List.of(f2)),
                     layout(f1, f2)
                 ).get(driverContext);
-                String desc = operation.endsWith("lazy") ? "CoalesceEvaluator" : "CoalesceEvaluator"; // NOCOMMIT eager/lazy here
+                String desc = operation.endsWith("lazy") ? "CoalesceLazyEvaluator" : "CoalesceEagerEvaluator";
                 if (evaluator.toString().contains(desc) == false) {
                     throw new IllegalArgumentException("Evaluator was [" + evaluator + "] but expected one containing [" + desc + "]");
                 }
@@ -284,7 +284,7 @@ private static void checkExpected(String operation, Page actual) {
                     }
                 }
             }
-            case "coalesce_1_noop" -> {
+            case "coalesce_2_noop" -> {
                 LongVector f1 = actual.<LongBlock>getBlock(0).asVector();
                 LongVector result = actual.<LongBlock>getBlock(2).asVector();
                 for (int i = 0; i < BLOCK_LENGTH; i++) {
@@ -294,7 +294,7 @@ private static void checkExpected(String operation, Page actual) {
                     }
                 }
             }
-            case "coalesce_1_eager" -> {
+            case "coalesce_2_eager" -> {
                 LongBlock f1 = actual.<LongBlock>getBlock(0);
                 LongVector f2 = actual.<LongBlock>getBlock(1).asVector();
                 LongVector result = actual.<LongBlock>getBlock(2).asVector();
@@ -305,7 +305,7 @@ private static void checkExpected(String operation, Page actual) {
                     }
                 }
             }
-            case "coalesce_1_lazy" -> {
+            case "coalesce_2_lazy" -> {
                 LongBlock f1 = actual.<LongBlock>getBlock(0);
                 LongVector f2 = actual.<LongBlock>getBlock(1).asVector();
                 LongVector result = actual.<LongBlock>getBlock(2).asVector();
@@ -380,7 +380,7 @@ private static Page page(String operation) {
                 }
                 yield new Page(builder.build());
             }
-            case "case_1_eager", "case_1_lazy", "coalesce_1_noop" -> {
+            case "case_1_eager", "case_1_lazy", "coalesce_2_noop" -> {
                 var f1 = blockFactory.newLongBlockBuilder(BLOCK_LENGTH);
                 var f2 = blockFactory.newLongBlockBuilder(BLOCK_LENGTH);
                 for (int i = 0; i < BLOCK_LENGTH; i++) {
@@ -389,7 +389,7 @@ private static Page page(String operation) {
                 }
                 yield new Page(f1.build(), f2.build());
             }
-            case "coalesce_1_eager", "coalesce_1_lazy" -> {
+            case "coalesce_2_eager", "coalesce_2_lazy" -> {
                 var f1 = blockFactory.newLongBlockBuilder(BLOCK_LENGTH);
                 var f2 = blockFactory.newLongBlockBuilder(BLOCK_LENGTH);
                 for (int i = 0; i < BLOCK_LENGTH; i++) {

x-pack/plugin/esql/compute/src/main/generated-src/org/elasticsearch/compute/data/BooleanBlockBuilder.java

@@ -120,6 +120,8 @@ $endif$
         return copyFrom(($Type$Block) block, beginInclusive, endExclusive);
     }
 
+    // NOCOMMIT it's slow to check if all values are null for single position copies.
+
     /**
      * Copy the values in {@code block} from {@code beginInclusive} to
      * {@code endExclusive} into this builder.