Skip to content

Commit 8ede964

Browse files
committed
Revert "[NVPTX] Enable lowering of atomics on local memory"
This reverts commit fede99d.
1 parent fede99d commit 8ede964

File tree

7 files changed

+2
-120
lines changed

7 files changed

+2
-120
lines changed

llvm/include/llvm/Transforms/Scalar/LowerAtomic.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,6 @@ class LowerAtomicPass : public PassInfoMixin<LowerAtomicPass> {
2424
PreservedAnalyses run(Function &F, FunctionAnalysisManager &);
2525
static bool isRequired() { return true; }
2626
};
27-
28-
class AtomicRMWInst;
29-
/// Convert the given RMWI into primitive load and stores,
30-
/// assuming that doing so is legal. Return true if the lowering
31-
/// succeeds.
32-
bool lowerAtomicRMWInst(AtomicRMWInst *RMWI);
3327
}
3428

3529
#endif // LLVM_TRANSFORMS_SCALAR_LOWERATOMIC_H

llvm/lib/Target/NVPTX/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ add_public_tablegen_target(NVPTXCommonTableGen)
1212

1313
set(NVPTXCodeGen_sources
1414
NVPTXAllocaHoisting.cpp
15-
NVPTXAtomicLower.cpp
1615
NVPTXAsmPrinter.cpp
1716
NVPTXAssignValidGlobalNames.cpp
1817
NVPTXFrameLowering.cpp

llvm/lib/Target/NVPTX/NVPTXAtomicLower.cpp

Lines changed: 0 additions & 67 deletions
This file was deleted.

llvm/lib/Target/NVPTX/NVPTXAtomicLower.h

Lines changed: 0 additions & 22 deletions
This file was deleted.

llvm/lib/Target/NVPTX/NVPTXTargetMachine.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
#include "NVPTXTargetMachine.h"
1414
#include "NVPTX.h"
1515
#include "NVPTXAllocaHoisting.h"
16-
#include "NVPTXAtomicLower.h"
1716
#include "NVPTXLowerAggrCopies.h"
1817
#include "NVPTXTargetObjectFile.h"
1918
#include "NVPTXTargetTransformInfo.h"
@@ -66,7 +65,6 @@ void initializeNVVMIntrRangePass(PassRegistry&);
6665
void initializeNVVMReflectPass(PassRegistry&);
6766
void initializeGenericToNVVMPass(PassRegistry&);
6867
void initializeNVPTXAllocaHoistingPass(PassRegistry &);
69-
void initializeNVPTXAtomicLowerPass(PassRegistry &);
7068
void initializeNVPTXAssignValidGlobalNamesPass(PassRegistry&);
7169
void initializeNVPTXLowerAggrCopiesPass(PassRegistry &);
7270
void initializeNVPTXLowerArgsPass(PassRegistry &);
@@ -88,7 +86,6 @@ extern "C" LLVM_EXTERNAL_VISIBILITY void LLVMInitializeNVPTXTarget() {
8886
initializeGenericToNVVMPass(PR);
8987
initializeNVPTXAllocaHoistingPass(PR);
9088
initializeNVPTXAssignValidGlobalNamesPass(PR);
91-
initializeNVPTXAtomicLowerPass(PR);
9289
initializeNVPTXLowerArgsPass(PR);
9390
initializeNVPTXLowerAllocaPass(PR);
9491
initializeNVPTXLowerAggrCopiesPass(PR);
@@ -255,7 +252,6 @@ void NVPTXPassConfig::addAddressSpaceInferencePasses() {
255252
addPass(createSROAPass());
256253
addPass(createNVPTXLowerAllocaPass());
257254
addPass(createInferAddressSpacesPass());
258-
addPass(createNVPTXAtomicLowerPass());
259255
}
260256

261257
void NVPTXPassConfig::addStraightLineScalarOptimizationPasses() {

llvm/lib/Transforms/Scalar/LowerAtomic.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ static bool LowerAtomicCmpXchgInst(AtomicCmpXchgInst *CXI) {
4040
return true;
4141
}
4242

43-
bool llvm::lowerAtomicRMWInst(AtomicRMWInst *RMWI) {
43+
static bool LowerAtomicRMWInst(AtomicRMWInst *RMWI) {
4444
IRBuilder<> Builder(RMWI);
4545
Value *Ptr = RMWI->getPointerOperand();
4646
Value *Val = RMWI->getValOperand();
@@ -123,7 +123,7 @@ static bool runOnBasicBlock(BasicBlock &BB) {
123123
else if (AtomicCmpXchgInst *CXI = dyn_cast<AtomicCmpXchgInst>(&Inst))
124124
Changed |= LowerAtomicCmpXchgInst(CXI);
125125
else if (AtomicRMWInst *RMWI = dyn_cast<AtomicRMWInst>(&Inst))
126-
Changed |= lowerAtomicRMWInst(RMWI);
126+
Changed |= LowerAtomicRMWInst(RMWI);
127127
else if (LoadInst *LI = dyn_cast<LoadInst>(&Inst)) {
128128
if (LI->isAtomic())
129129
LowerLoadInst(LI);

llvm/test/CodeGen/NVPTX/atomic-lower-local.ll

Lines changed: 0 additions & 18 deletions
This file was deleted.

0 commit comments

Comments
 (0)