Skip to content

Commit 6b05823

Browse files
authored
Update php versions tested in CI, prepare the 1.0.15 release (#218)
* Update php versions tested in CI PHP '8.1' isn't published yet on docker hub. Start testing with php 8.1 in appveyor * Prepare for a 1.0.15 release Make it possible to test with php 8.2 without deprecation notes for endLineno, etc. See #217 Also, document how to properly update cache slot numbers if new properties are added to ast\Node in the future.
1 parent e36cc7d commit 6b05823

File tree

6 files changed

+41
-18
lines changed

6 files changed

+41
-18
lines changed

.appveyor.yml

Lines changed: 32 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -32,22 +32,42 @@ environment:
3232
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
3333
ARCH: x86
3434
VC: vs16
35-
PHP_VER: 8.0.3
35+
PHP_VER: 8.1.0
3636
TS: 1
3737
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
3838
ARCH: x64
3939
VC: vs16
40-
PHP_VER: 8.0.3
40+
PHP_VER: 8.1.0
4141
TS: 1
4242
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
4343
ARCH: x86
4444
VC: vs16
45-
PHP_VER: 8.0.3
45+
PHP_VER: 8.1.0
4646
TS: 0
4747
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
4848
ARCH: x64
4949
VC: vs16
50-
PHP_VER: 8.0.3
50+
PHP_VER: 8.1.0
51+
TS: 0
52+
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
53+
ARCH: x86
54+
VC: vs16
55+
PHP_VER: 8.0.13
56+
TS: 1
57+
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
58+
ARCH: x64
59+
VC: vs16
60+
PHP_VER: 8.0.13
61+
TS: 1
62+
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
63+
ARCH: x86
64+
VC: vs16
65+
PHP_VER: 8.0.13
66+
TS: 0
67+
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2019
68+
ARCH: x64
69+
VC: vs16
70+
PHP_VER: 8.0.13
5171
TS: 0
5272
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2015
5373
ARCH: x64
@@ -112,42 +132,42 @@ environment:
112132
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
113133
ARCH: x64
114134
VC: vc15
115-
PHP_VER: 7.3.25
135+
PHP_VER: 7.3.33
116136
TS: 0
117137
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
118138
ARCH: x64
119139
VC: vc15
120-
PHP_VER: 7.3.27
140+
PHP_VER: 7.3.33
121141
TS: 1
122142
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
123143
ARCH: x86
124144
VC: vc15
125-
PHP_VER: 7.3.27
145+
PHP_VER: 7.3.33
126146
TS: 0
127147
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
128148
ARCH: x86
129149
VC: vc15
130-
PHP_VER: 7.3.27
150+
PHP_VER: 7.3.33
131151
TS: 1
132152
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
133153
ARCH: x64
134154
VC: vc15
135-
PHP_VER: 7.4.16
155+
PHP_VER: 7.4.26
136156
TS: 0
137157
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
138158
ARCH: x64
139159
VC: vc15
140-
PHP_VER: 7.4.16
160+
PHP_VER: 7.4.26
141161
TS: 1
142162
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
143163
ARCH: x86
144164
VC: vc15
145-
PHP_VER: 7.4.16
165+
PHP_VER: 7.4.26
146166
TS: 0
147167
- APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
148168
ARCH: x86
149169
VC: vc15
150-
PHP_VER: 7.4.16
170+
PHP_VER: 7.4.26
151171
TS: 1
152172

153173
build_script:

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
- PHP_VERSION: '7.3'
3434
- PHP_VERSION: '7.4'
3535
- PHP_VERSION: '8.0'
36-
- PHP_VERSION: '8.1.0beta1'
36+
- PHP_VERSION: '8.1.0RC6'
3737

3838
# Steps represent a sequence of tasks that will be executed as part of the job
3939
steps:

ast.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
#define ast_register_flag_constant(name, value) \
5151
REGISTER_NS_LONG_CONSTANT("ast\\flags", name, value, CONST_CS | CONST_PERSISTENT)
5252

53+
// The number of cache slots there are must be the same as AST_NUM_CACHE_SLOTS in php_ast.h
5354
#define AST_CACHE_SLOT_KIND &AST_G(cache_slots)[3 * 0]
5455
#define AST_CACHE_SLOT_FLAGS &AST_G(cache_slots)[3 * 1]
5556
#define AST_CACHE_SLOT_LINENO &AST_G(cache_slots)[3 * 2]

ci/test_dockerized.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ fi
1010
# -u fail for undefined variables
1111
set -xeu
1212
PHP_VERSION=$1
13-
DOCKER_IMAGE=php-ast-$PHP_VERSION-test-runner
13+
# uppercase is not allowed in image names, only in tags
14+
DOCKER_IMAGE=php-ast-test-runner:$PHP_VERSION
1415
docker build --build-arg="PHP_VERSION=$PHP_VERSION" --tag="$DOCKER_IMAGE" -f ci/Dockerfile .
1516
docker run --rm $DOCKER_IMAGE ci/test_inner.sh

package.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@
1818
<email>[email protected]</email>
1919
<active>yes</active>
2020
</lead>
21-
<date>2021-07-24</date>
21+
<date>2021-11-27</date>
2222
<version>
23-
<release>1.0.15dev</release>
24-
<api>1.0.15dev</api>
23+
<release>1.0.15</release>
24+
<api>1.0.15</api>
2525
</version>
2626
<stability>
2727
<release>devel</release>

php_ast.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
extern zend_module_entry ast_module_entry;
88
#define phpext_ast_ptr &ast_module_entry
99

10-
#define PHP_AST_VERSION "1.0.15-dev"
10+
#define PHP_AST_VERSION "1.0.15"
1111

1212
#ifdef PHP_WIN32
1313
# define PHP_AST_API __declspec(dllexport)
@@ -23,6 +23,7 @@ extern zend_module_entry ast_module_entry;
2323

2424
// PHP 7.4 added a 3rd cache slot for property_info
2525
// and expects cache_slot[2] to be null.
26+
// There are 4 entries in ast.c in `AST_CACHE_SLOT_*`
2627
#define AST_NUM_CACHE_SLOTS (3 * 4)
2728

2829
ZEND_BEGIN_MODULE_GLOBALS(ast)

0 commit comments

Comments
 (0)