Line number for function parameter definition

[SergiiDolgushev]

I was using the following test file:

<?php
function doSomethingNice(
    int $param
): void {
    return;
}

That was checked using the following code

<?php

$contents = \file_get_contents('test.php');
$ast = \ast\parse_code($contents, 90);
$parmLineDeclarion = $ast->children[0]->children['params']->children[0]->lineno;

echo 'PHP version: ' . phpversion() . ' php-ast version: ' . (new \ReflectionExtension('ast'))->getVersion() . PHP_EOL;
echo 'Param declared on line #' . $parmLineDeclarion . PHP_EOL;

And different results were produced for PHP 8.2 vs PHP 8.4. Seems like PHP 8.4 wrongly returns 4 instead of 3:

PHP version: 8.2.18 php-ast version: 1.1.0
Param declared on line #3 

PHP version: 8.4.7 php-ast version: 1.1.2
Param declared on line #4

Once test file is changed so function declaration ends on the same line where the $params is defined, the same result is returned in both cases:

<?php
function doSomethingNice(
    int $param): void {
    return;
}

=>

PHP version: 8.2.18 php-ast version: 1.1.0
Param declared on line #3

and

PHP version: 8.4.7 php-ast version: 1.1.2
Param declared on line #3

[SergiiDolgushev]

I've tried to run php-ast version: 1.1.2 on php 8.2, and it also returns expected 3. So seems like the issue is introduced in php 8.4 (but not in the latest php-ast releases):

PHP version: 8.2.18 php-ast version: 1.1.0
Param declared on line #3 

PHP version: 8.2.28 php-ast version: 1.1.2
Param declared on line #3

PHP version: 8.4.7 php-ast version: 1.1.2
Param declared on line #4

[nikic]

This is a bug in php-src: php/php-src#18732

[SergiiDolgushev]

@nikic thank you very much for the quick fix. Is there a chance your fix will be included in 8.4.8?

[nikic]

@SergiiDolgushev No, this will be part of 8.4.9.

[SergiiDolgushev]

Thank you very much! :) As this was a bug in php-src, seems like once 8.4.9 is released, it will be fixed? Just want to confirm that no new version of php-ast will be required?