Fix TaskletStep to propagate checked exceptions when rollback is disabled

Fixes spring-projects#5316

Propagate checked exceptions from Tasklet.execute even when
transactionAttribute.rollbackOn(e) returns false. Only mark rollback
metadata (ROLLBACK_EXCEPTION_KEY and rollback count) when rollback is
actually configured for the exception.

Also add regression tests for PROPAGATION_NOT_SUPPORTED to ensure a
checked exception fails the step instead of being silently retried.

Signed-off-by: Nikita Nagar <permanayan84@gmail.com>

Author: nikitanagar08

spring-batch-core/src/main/java/org/springframework/batch/core/step/tasklet/TaskletStep.java

@@ -417,8 +417,8 @@ public RepeatStatus doInTransaction(TransactionStatus status) {
 					catch (Exception e) {
 						if (transactionAttribute.rollbackOn(e)) {
 							chunkContext.setAttribute(ChunkListener.ROLLBACK_EXCEPTION_KEY, e);
-							throw e;
 						}
+						throw e;
 					}
 				}
 				finally {

spring-batch-core/src/test/java/org/springframework/batch/core/step/item/TaskletStepExceptionTests.java

@@ -39,6 +39,7 @@
 import org.jspecify.annotations.Nullable;
 import org.springframework.transaction.TransactionException;
 import org.springframework.transaction.UnexpectedRollbackException;
+import org.springframework.transaction.interceptor.DefaultTransactionAttribute;
 import org.springframework.transaction.support.DefaultTransactionStatus;
 import org.springframework.transaction.support.TransactionSynchronizationManager;
 
@@ -574,6 +575,64 @@ public JobInstance createJobInstance(String jobName, JobParameters jobParameters
 
 	}
 
+	@Test
+	void testCheckedExceptionPropagatedWhenRollbackDisabled() throws Exception {
+		// Test for regression of issue where checked exceptions were swallowed
+		// when transactionAttribute.rollbackOn(ex) returned false
+		taskletStep.setTransactionAttribute(new DefaultTransactionAttribute() {
+			@Override
+			public boolean rollbackOn(Throwable ex) {
+				// Simulate PROPAGATION_NOT_SUPPORTED behavior - no rollback for checked exceptions
+				if (ex instanceof RuntimeException) {
+					return true;
+				}
+				return false;
+			}
+		});
+
+		// Create a tasklet that throws a checked exception
+		taskletStep.setTasklet(new Tasklet() {
+			@Nullable
+			@Override
+			public RepeatStatus execute(StepContribution contribution, ChunkContext chunkContext) throws Exception {
+				throw new Exception("Checked exception from tasklet");
+			}
+		});
+
+		// Execute should fail with the checked exception
+		taskletStep.execute(stepExecution);
+		assertEquals(FAILED, stepExecution.getStatus());
+		assertTrue(stepExecution.getFailureExceptions().get(0) instanceof Exception);
+		assertEquals("Checked exception from tasklet",
+				stepExecution.getFailureExceptions().get(0).getMessage());
+	}
+
+	@Test
+	void testRuntimeExceptionPropagatedWhenRollbackDisabled() throws Exception {
+		// Even for runtime exceptions, they should be propagated
+		taskletStep.setTransactionAttribute(new DefaultTransactionAttribute() {
+			@Override
+			public boolean rollbackOn(Throwable ex) {
+				// Disable rollback for all exceptions
+				return false;
+			}
+		});
+
+		// Create a tasklet that throws a runtime exception
+		taskletStep.setTasklet(new Tasklet() {
+			@Nullable
+			@Override
+			public RepeatStatus execute(StepContribution contribution, ChunkContext chunkContext) throws Exception {
+				throw new RuntimeException("Runtime exception from tasklet");
+			}
+		});
+
+		// Execute should fail with the runtime exception
+		taskletStep.execute(stepExecution);
+		assertEquals(FAILED, stepExecution.getStatus());
+		assertTrue(stepExecution.getFailureExceptions().get(0) instanceof RuntimeException);
+	}
+
 	private static class FailingRollbackTransactionManager extends ResourcelessTransactionManager {
 
 		@Override