Skip to content

Prevent automatic merge if configured review team was not found #20

@nikku

Description

@nikku

Describe the issue

If review teams are configured, the app, by design requires these teams to be configured (and assigned to team members) on GitHub, too or otherwise the automatic merge won't work as expected. In fact, right now, the bot will simply assume these teams do not exist and thus merge once the first review comes in.

Steps to reproduce

  • Configure reviewTeams: A & B
  • Do not configure / grant review teams permissions on GitHub
  • Let member of team A review
  • Automatic merge is happening, without waiting for approval from team B

Expected Behavior

If configured teams are not accessible on GitHub, this is a configuration problem / miss-match. We should not do anything at all.

Related

Adding a status check and indicating why a merge cannot happen (i.e. hinting on the configuration error) would be nice to have, cf. #2.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions