fix build tests

Author: nikolainobadi

Sources/nnex/Controllers/BuildController.swift

@@ -45,7 +45,7 @@ extension BuildController {
 // MARK: - PublishBuilder
 extension BuildController {
     func buildExecutable(projectFolder: any Directory, buildType: BuildType, clean: Bool, outputLocation: BuildOutputLocation?, extraBuildArgs: [String], testCommand: HomebrewFormula.TestCommand?) throws -> BuildResult {
-        let outputLocation = try selectOutputLocation(buildType: buildType)
+        let outputLocation = outputLocation ?? .currentDirectory(buildType)
         let config = try makeBuildConfig(for: projectFolder, buildType: buildType, clean: clean, extraArgs: extraBuildArgs, testCommand: testCommand)
 
         return try buildService.buildExecutable(config: config, outputLocation: outputLocation)

Sources/nnex/Publish/Adapters/ArtifactDelegateAdapter.swift

@@ -25,6 +25,6 @@ extension ArtifactDelegateAdapter: ArtifactDelegate {
     }
 
     func buildExecutable(projectFolder: any Directory, buildType: BuildType, extraBuildArgs: [String], testCommand: HomebrewFormula.TestCommand?) throws -> BuildResult {
-        return try buildController.buildExecutable(projectFolder: projectFolder, buildType: buildType, clean: true, outputLocation: .currentDirectory(buildType), extraBuildArgs: extraBuildArgs, testCommand: testCommand)
+        return try buildController.buildExecutable(projectFolder: projectFolder, buildType: buildType, clean: true, outputLocation: nil, extraBuildArgs: extraBuildArgs, testCommand: testCommand)
     }
 }

Tests/nnexTests/IntegrationTests/BuildTests/BuildExecutableTests.swift

@@ -114,7 +114,7 @@ extension BuildTests {
         #expect(!shell.executedCommand(containing: "cp"))
     }
 
-    @Test("Builds to desktop when selected", .disabled()) // TODO: -
+    @Test("Builds to desktop when selected")
     func buildsToDesktopWhenSelected() throws {
         let armSha256 = "arm123def456"
         let intelSha256 = "intel123def456"
@@ -130,7 +130,7 @@ extension BuildTests {
         #expect(shell.executedCommand(containing: "Desktop"))
     }
 
-    @Test("Prompts for custom location and confirms path", .disabled()) // TODO: -
+    @Test("Prompts for custom location and confirms path")
     func promptsForCustomLocationAndConfirmsPath() throws {
         let armSha256 = "arm123def456"
         let intelSha256 = "intel123def456"
@@ -176,7 +176,7 @@ extension BuildTests {
         } catch { }
     }
 
-    @Test("Copies binary to selected output location", .disabled()) // TODO: -
+    @Test("Copies binary to selected output location")
     func copiesBinaryToSelectedOutputLocation() throws {
         let armSha256 = "arm123def456"
         let intelSha256 = "intel123def456"

Tests/nnexTests/UnitTests/BuildControllerTests.swift

@@ -55,47 +55,16 @@ extension BuildControllerTests {
     func selectsCurrentDirectoryAsOutput() throws {
         let projectDirectory = try makeProjectDirectory(path: "/project/app", executableNames: ["app"])
         let (sut, service, _) = makeSUT(projectDirectory: projectDirectory, selectedIndex: 0)
-
+        
         try sut.buildExecutable(path: nil, buildType: .x86_64, clean: true, openInFinder: false)
-
+        
         let buildData = try #require(service.buildData)
         if case .currentDirectory(let buildType) = buildData.outputLocation {
             #expect(buildType == .x86_64)
         } else {
             Issue.record("Expected currentDirectory output location")
         }
     }
-
-    @Test("Selects desktop as output location")
-    func selectsDesktopAsOutput() throws {
-        let projectDirectory = try makeProjectDirectory(path: "/project/app", executableNames: ["app"])
-        let (sut, service, _) = makeSUT(projectDirectory: projectDirectory, selectedIndex: 1)
-
-        try sut.buildExecutable(path: nil, buildType: .universal, clean: true, openInFinder: false)
-
-        let buildData = try #require(service.buildData)
-        if case .desktop = buildData.outputLocation {
-            // Success
-        } else {
-            Issue.record("Expected desktop output location")
-        }
-    }
-
-    @Test("Handles custom output location with folder browser", .disabled()) // TODO: - 
-    func handlesCustomOutputLocation() throws {
-        let projectDirectory = try makeProjectDirectory(path: "/project/app", executableNames: ["app"])
-        let customFolder = MockDirectory(path: "/custom/location")
-        let (sut, service, _) = makeSUT(projectDirectory: projectDirectory, selectedIndex: 2, permissionResponses: [true], browsedDirectory: customFolder)
-
-        try sut.buildExecutable(path: nil, buildType: .universal, clean: true, openInFinder: false)
-
-        let buildData = try #require(service.buildData)
-        if case .custom(let path) = buildData.outputLocation {
-            #expect(path == "/custom/location")
-        } else {
-            Issue.record("Expected custom output location")
-        }
-    }
 }