Fix analytics bugs: anomaly z-score sign, cache mode_config, bot logging

Author: nikolay-e

src/analytics/clinical.py

@@ -272,10 +272,10 @@ def check_metric(
             if d.value is None:
                 continue
             raw_z = (d.value - bl.mean) / bl.std
-            z = -raw_z if invert else raw_z
-            if not both_directions and z < 0:
+            directional_z = -raw_z if invert else raw_z
+            if not both_directions and directional_z < 0:
                 continue
-            abs_z = abs(z)
+            abs_z = abs(raw_z)
             if abs_z >= ANOMALY_THRESHOLDS["warning"]:
                 if abs_z >= ANOMALY_THRESHOLDS["critical"]:
                     severity = "critical"
@@ -288,7 +288,7 @@ def check_metric(
                         date=d.date,
                         metric=display_name,
                         value=d.value,
-                        z_score=z,
+                        z_score=raw_z,
                         severity=severity,
                     )
                 )

src/analytics/pipeline.py

@@ -6,6 +6,7 @@
 
 from sqlalchemy.orm import Session
 
+from .constants import TREND_MODES
 from .date_utils import local_today
 from .service import compute_health_analysis
 from .types import HealthAnalysis, TrendMode
@@ -79,8 +80,13 @@ def get_cached_snapshot(
         return None
 
     try:
+        config = TREND_MODES[mode]
         return HealthAnalysis.model_validate(  # type: ignore[no-any-return]
-            {**existing.snapshot_json, "mode": mode.value, "mode_config": {}}
+            {
+                **existing.snapshot_json,
+                "mode": mode.value,
+                "mode_config": config.model_dump(),
+            }
         )
     except Exception:
         logger.warning(

src/analytics/smart_context.py

@@ -134,6 +134,11 @@ def build_smart_context(analysis: HealthAnalysis, max_anomalies: int = 3) -> dic
 
     ctx["day_completeness"] = analysis.day_completeness
 
+    if analysis.data_source_summary:
+        ctx["data_source_summary"] = [
+            s.model_dump(exclude_none=True) for s in analysis.data_source_summary
+        ]
+
     return ctx
 
 

src/bot/__init__.py

@@ -1,8 +1,10 @@
 from bot.bot import create_bot
 from bot.config import BotConfig
+from logging_config import configure_logging
 
 
 def main():
+    configure_logging()
     config = BotConfig()
     app = create_bot(config)
     app.run_polling()