fix(behat): make the CI green

nikophil · nikophil · commit 00c164d1f01c · 2026-02-04T19:15:52.000+01:00
diff --git a/.github/workflows/behat.yml b/.github/workflows/behat.yml
@@ -30,6 +30,9 @@ jobs:
         deps: [ highest, lowest ]
     env:
       DATABASE_URL: 'sqlite:///%kernel.project_dir%/var/data.db'
+      USE_DAMA_DOCTRINE_TEST_BUNDLE: 1
+      USE_PHP_84_LAZY_OBJECTS: 1
+      MONGO_URL: ''
     steps:
       - name: Checkout code
         uses: actions/checkout@v3
@@ -59,25 +62,25 @@ jobs:
           SYMFONY_REQUIRE: ${{ matrix.symfony }}
 
       - name: "Main test suite: reset DB at scenario level, with Dama support"
-        run: vendor/bin/behat
+        run: vendor/bin/behat --colors -vvv
 
       - name: "Main test suite: reset DB at scenario level, without Dama support"
-        run: vendor/bin/behat --profile=main-no-dama
+        run: vendor/bin/behat --colors -vvv --profile=main-no-dama
 
       - name: "Main test suite: reset DB at scenario level, with native Dama extension"
-        run: vendor/bin/behat --profile=main-native-dama --tags='~@skip-with-native-dama'
+        run: vendor/bin/behat --colors -vvv --profile=main-native-dama --tags='~@skip-with-native-dama'
 
       - name: Manual reset DB
-        run: vendor/bin/behat --profile=reset-manual
+        run: vendor/bin/behat --colors -vvv --profile=reset-manual
 
       - name: Manual reset DB and Dama support
-        run: vendor/bin/behat --profile=reset-manual-dama
+        run: vendor/bin/behat --colors -vvv --profile=reset-manual-dama
 
       - name: Reset DB at feature level
-        run: vendor/bin/behat --profile=reset-feature
+        run: vendor/bin/behat --colors -vvv --profile=reset-feature
 
       - name: Reset DB at feature level with Dama support
-        run: vendor/bin/behat --profile=reset-feature-dama
+        run: vendor/bin/behat --colors -vvv --profile=reset-feature-dama
 
       - name: Reset DB disabled
-        run: vendor/bin/behat --profile=reset-disabled
+        run: vendor/bin/behat --colors -vvv --profile=reset-disabled
diff --git a/.github/workflows/phpunit.yml b/.github/workflows/phpunit.yml
@@ -252,7 +252,7 @@ jobs:
 
       - name: Test
         run: |
-          vendor/bin/phpunit tests/Unit
+          vendor/bin/phpunit -c phpunit-10.xml.dist tests/Unit
 
   test-with-paratest:
     name: Test with paratest
diff --git a/bin/tools/behat/composer.json b/bin/tools/behat/composer.json
@@ -5,7 +5,9 @@
         "friends-of-behat/mink-extension": "^2.0",
         "friends-of-behat/symfony-extension": "^2.0",
         "symfony/flex": "^2.10",
-        "yceruto/behat-extension": "^1.0"
+        "yceruto/behat-extension": "^1.0.2",
+        "symfony/polyfill-php84": "^1.33",
+        "symfony/polyfill-php85": "^1.33"
     },
     "config": {
         "allow-plugins": {
diff --git a/composer.json b/composer.json
@@ -47,6 +47,7 @@
         "symfony/framework-bundle": "^6.4|^7.0|^8.0",
         "symfony/maker-bundle": "^1.55",
         "symfony/phpunit-bridge": "^6.4.26|^7.0|^8.0",
+        "symfony/polyfill-php80": "^1.16",
         "symfony/routing": "^6.4|^7.0|^8.0",
         "symfony/runtime": "^6.4|^7.0|^8.0",
         "symfony/translation-contracts": "^3.4",
diff --git a/docs/index.rst b/docs/index.rst
@@ -2702,7 +2702,7 @@ Installation
 
     $ composer require --dev behat/behat friends-of-behat/symfony-extension
 
-2. Enable the Foundry extension in your ``behat.yml``:
+2. Enable the Foundry extension in your ``behat.yaml``:
 
 .. code-block:: yaml
 
diff --git a/phpunit-10.xml.dist b/phpunit-10.xml.dist
@@ -20,6 +20,8 @@
         <testsuite name="main">
             <directory>tests</directory>
             <exclude>tests/Integration/ResetDatabase</exclude>
+            <exclude>tests/Unit/Test/Behat</exclude>
+            <exclude>tests/Unit/Integration/Behat</exclude>
         </testsuite>
         <testsuite name="reset-database">
             <directory>tests/Integration/ResetDatabase</directory>
diff --git a/phpunit-paratest.xml.dist b/phpunit-paratest.xml.dist
@@ -26,6 +26,8 @@
         <testsuite name="main">
             <directory>tests</directory>
             <exclude>tests/Integration/ResetDatabase</exclude>
+            <exclude>tests/Unit/Test/Behat</exclude>
+            <exclude>tests/Unit/Integration/Behat</exclude>
         </testsuite>
     </testsuites>
     <source ignoreSuppressionOfDeprecations="true" baseline="phpunit-deprecation-baseline.xml">
diff --git a/src/Test/Behat/FoundryTableNode.php b/src/Test/Behat/FoundryTableNode.php
@@ -53,7 +53,7 @@ public static function create(
         return $tableNode;
     }
 
-    public function getRowAsString(int $rowNum): string
+    public function getRowAsString($rowNum): string
     {
         $values = [];
         foreach ($this->getRow($rowNum) as $column => $value) {
@@ -63,7 +63,7 @@ public function getRowAsString(int $rowNum): string
         return sprintf('|%s|', implode('|', $values));
     }
 
-    public function getRowAsStringWithWrappedValues(int $rowNum, callable $wrapper): string
+    public function getRowAsStringWithWrappedValues($rowNum, $wrapper): string
     {
         $values = [];
         foreach ($this->getRow($rowNum) as $column => $value) {
diff --git a/tests/Integration/Behat/Listener/BootConfigurationListenerTest.php b/tests/Integration/Behat/Listener/BootConfigurationListenerTest.php
@@ -13,6 +13,7 @@
 
 namespace Zenstruck\Foundry\Tests\Integration\Behat\Listener;
 
+use PHPUnit\Framework\Attributes\RequiresPhp;
 use PHPUnit\Framework\Attributes\Test;
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Zenstruck\Foundry\Configuration;
@@ -24,6 +25,7 @@
 use Zenstruck\Foundry\Tests\Fixture\Factories\Entity\GenericEntityFactory;
 use Zenstruck\Foundry\Tests\Integration\RequiresORM;
 
+#[RequiresPhp('9')]
 final class BootConfigurationListenerTest extends KernelTestCase
 {
     use Factories, RequiresORM, ResetDatabase;
diff --git a/tests/Integration/Behat/Listener/DatabaseResetListenerTest.php b/tests/Integration/Behat/Listener/DatabaseResetListenerTest.php
@@ -20,6 +20,7 @@
 use Behat\Testwork\Environment\StaticEnvironment;
 use Behat\Testwork\Suite\GenericSuite;
 use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\Attributes\RequiresPhp;
 use PHPUnit\Framework\Attributes\Test;
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Zenstruck\Foundry\Test\Behat\DatabaseResetMode;
@@ -33,6 +34,7 @@
 use Zenstruck\Foundry\Tests\Fixture\Factories\Entity\GenericEntityFactory;
 use Zenstruck\Foundry\Tests\Integration\RequiresORM;
 
+#[RequiresPhp('9')]
 final class DatabaseResetListenerTest extends KernelTestCase
 {
     use Factories, RequiresORM, ResetDatabase;
diff --git a/tests/Integration/Behat/Listener/LoadFixturesListenerTest.php b/tests/Integration/Behat/Listener/LoadFixturesListenerTest.php
@@ -20,6 +20,7 @@
 use Behat\Testwork\Environment\Environment;
 use Behat\Testwork\Tester\Setup\Setup;
 use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\Attributes\RequiresPhp;
 use PHPUnit\Framework\Attributes\Test;
 use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase;
 use Zenstruck\Foundry\Test\Behat\Exception\ObjectAlreadyRegistered;
@@ -33,6 +34,7 @@
 use Zenstruck\Foundry\Tests\Fixture\Factories\Entity\Category\CategoryFactory;
 use Zenstruck\Foundry\Tests\Integration\RequiresORM;
 
+#[RequiresPhp('9')]
 final class LoadFixturesListenerTest extends KernelTestCase
 {
     use Factories, RequiresORM, ResetDatabase;
diff --git a/tests/Unit/Test/Behat/FactoryResolverTest.php b/tests/Unit/Test/Behat/FactoryResolverTest.php
@@ -14,13 +14,15 @@
 namespace Zenstruck\Foundry\Tests\Unit\Test\Behat;
 
 use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\Attributes\RequiresPhp;
 use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\TestCase;
 use Zenstruck\Foundry\Attribute\FactoryShortName;
 use Zenstruck\Foundry\ObjectFactory;
 use Zenstruck\Foundry\Test\Behat\Exception\FactoryNotResolvable;
 use Zenstruck\Foundry\Test\Behat\FactoryShortNameResolver;
 
+#[RequiresPhp('9')]
 final class FactoryResolverTest extends TestCase
 {
     public static function factoriesWithConflictingShortNames(): iterable
diff --git a/tests/Unit/Test/Behat/FoundryCallFilterTest.php b/tests/Unit/Test/Behat/FoundryCallFilterTest.php
@@ -22,6 +22,7 @@
 use Behat\Testwork\Call\Call;
 use Behat\Testwork\Environment\Environment;
 use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\Attributes\RequiresPhp;
 use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\DependencyInjection\ContainerInterface;
@@ -36,6 +37,7 @@
 use Zenstruck\Foundry\Test\Behat\Exception\InvalidObjectParameter;
 use Zenstruck\Foundry\Test\Behat\ObjectRegistry;
 
+#[RequiresPhp('9')]
 final class FoundryCallFilterTest extends TestCase
 {
     private FoundryCallFilter $filter;
diff --git a/tests/Unit/Test/Behat/FoundryTableNodeTest.php b/tests/Unit/Test/Behat/FoundryTableNodeTest.php
@@ -14,6 +14,7 @@
 namespace Zenstruck\Foundry\Tests\Unit\Test\Behat;
 
 use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\Attributes\RequiresPhp;
 use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\TestCase;
 use Zenstruck\Foundry\Attribute\FactoryShortName;
@@ -23,6 +24,7 @@
 use Zenstruck\Foundry\Test\Behat\FoundryTableNode;
 use Zenstruck\Foundry\Test\Behat\ObjectRegistry;
 
+#[RequiresPhp('9')]
 final class FoundryTableNodeTest extends TestCase
 {
     private FactoryShortNameResolver $factoryResolver;
diff --git a/tests/Unit/Test/Behat/ObjectRegistryTest.php b/tests/Unit/Test/Behat/ObjectRegistryTest.php
@@ -13,6 +13,7 @@
 
 namespace Zenstruck\Foundry\Tests\Unit\Test\Behat;
 
+use PHPUnit\Framework\Attributes\RequiresPhp;
 use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\TestCase;
 use Zenstruck\Foundry\ObjectFactory;
@@ -25,6 +26,7 @@
 use Zenstruck\Foundry\Test\Behat\Exception\ObjectNotFound;
 use Zenstruck\Foundry\Test\Behat\ObjectRegistry;
 
+#[RequiresPhp('9')]
 final class ObjectRegistryTest extends TestCase
 {
     private ObjectRegistry $registry;
diff --git a/tests/bootstrap.php b/tests/bootstrap.php
@@ -21,7 +21,6 @@
 }
 
 require \dirname(__DIR__).'/vendor/autoload.php';
-require \dirname(__DIR__).'/bin/tools/behat/vendor/autoload.php';
 
 $fs = new Filesystem();
 

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public static function create(`
`53`	`53`	`return $tableNode;`
`54`	`54`	`}`
`55`	`55`
`56`		`- public function getRowAsString(int $rowNum): string`
	`56`	`+ public function getRowAsString($rowNum): string`
`57`	`57`	`{`
`58`	`58`	`$values = [];`
`59`	`59`	`foreach ($this->getRow($rowNum) as $column => $value) {`
`@@ -63,7 +63,7 @@ public function getRowAsString(int $rowNum): string`
`63`	`63`	`return sprintf('\|%s\|', implode('\|', $values));`
`64`	`64`	`}`
`65`	`65`
`66`		`- public function getRowAsStringWithWrappedValues(int $rowNum, callable $wrapper): string`
	`66`	`+ public function getRowAsStringWithWrappedValues($rowNum, $wrapper): string`
`67`	`67`	`{`
`68`	`68`	`$values = [];`
`69`	`69`	`foreach ($this->getRow($rowNum) as $column => $value) {`