chore(behat): make phpstan & behat tests working

Author: nikophil

.github/workflows/behat.yml

@@ -29,11 +29,6 @@ jobs:
         php: [ 8.3, 8.5 ]
         symfony: [ 6.4.*, 7.4.* ]
         deps: [ highest, lowest ]
-    env:
-      DATABASE_URL: 'sqlite:///%kernel.project_dir%/var/data.db'
-      USE_DAMA_DOCTRINE_TEST_BUNDLE: 1
-      USE_PHP_84_LAZY_OBJECTS: 1
-      MONGO_URL: ''
     steps:
       - name: Checkout code
         uses: actions/checkout@v3
@@ -81,3 +76,70 @@ jobs:
 
       - name: Reset DB disabled
         run: vendor/bin/behat --colors -vvv --profile=reset-disabled
+
+  phpunit:
+    name: P:${{ matrix.php }}, S:${{ matrix.symfony }}${{ matrix.deps == 'lowest' && ' (lowest)' || '' }}
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        php: [ 8.3, 8.5 ]
+        symfony: [ 6.4.*, 7.4.* ]
+        deps: [ highest, lowest ]
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php }}
+          coverage: none
+          tools: flex
+
+      - name: Add the polyfill compatible with Doctrine ^2.16
+        if: ${{ matrix.deps == 'lowest' }}
+        run: composer require --dev symfony/polyfill-php80:^1.16 --no-update
+
+      - name: Install dependencies
+        uses: ramsey/composer-install@v2
+        with:
+          working-directory: "src/Test/Behat"
+          dependency-versions: ${{ matrix.deps }}
+          composer-options: --prefer-dist
+        env:
+          SYMFONY_REQUIRE: ${{ matrix.symfony }}
+
+      - name: Run tests
+        run: vendor/bin/phpunit
+
+  phpstan:
+    name: PhpStan
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v3
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: 8.5
+          coverage: none
+          tools: flex
+
+      - name: Install dependencies
+        uses: ramsey/composer-install@v2
+        with:
+          working-directory: "src/Test/Behat"
+          composer-options: --prefer-dist
+        env:
+          SYMFONY_REQUIRE: 7.4.*
+
+      - name: Install PHPStan
+        run: composer bin phpstan install
+
+      - name: Install PHPBench & Behat
+        run: composer bin phpbench install
+
+      - name: Run PHPStan
+        run: bin/tools/phpstan/vendor/phpstan/phpstan/phpstan analyse

bin/tools/behat/.gitignore

@@ -103,7 +103,14 @@
         }
     },
     "scripts": {
-        "post-install-cmd": ["@composer bin phpstan install", "@composer bin phpbench install", "@composer bin behat install"]
+        "post-install-cmd": [
+            "@composer bin phpstan install",
+            "@composer bin phpbench install",
+            "@composer update --working-dir=src/Test/Behat"
+        ],
+        "post-update-cmd": [
+            "@composer run-script post-install-cmd"
+        ]
     },
     "minimum-stability": "dev",
     "prefer-stable": true

bin/tools/behat/composer.json

@@ -11,7 +11,7 @@
          defaultTestSuite="main">
     <php>
         <ini name="error_reporting" value="-1"/>
-        <server name="KERNEL_CLASS" value="Zenstruck\Foundry\Test\Behat\Tests\Fixture\BehatTestKernel"/>
+        <server name="KERNEL_CLASS" value="Zenstruck\Foundry\Tests\Fixture\TestKernel"/>
         <server name="SHELL_VERBOSITY" value="-1"/>
         <env name="SYMFONY_DEPRECATIONS_HELPER" value="disabled"/>
         <env name="APP_ENV" value="test"/>

bin/tools/behat/symfony.lock

@@ -0,0 +1,18 @@
+#!/usr/bin/env php
+<?php
+
+use Symfony\Bundle\FrameworkBundle\Console\Application;
+use Zenstruck\Foundry\Test\Behat\Tests\Fixture\BehatTestKernel;
+
+require_once __DIR__ . '/../tests/bootstrap.php';
+
+foreach ($argv ?? [] as $i => $arg) {
+    if (($arg === '--env' || $arg === '-e') && isset($argv[$i + 1])) {
+        $_ENV['APP_ENV'] = $argv[$i + 1];
+        break;
+    }
+}
+
+$application = new Application(new BehatTestKernel($_ENV['APP_ENV'], true));
+
+$application->run();

composer.json

@@ -10,69 +10,24 @@ parameters:
     checkMissingCallableSignature: true
 
     paths:
-        - config?
-        - src
-        - tests
+        - ./config
+        - ./src
+        - ./tests
 
     banned_code:
         non_ignorable: false
 
     bootstrapFiles:
-        - bin/tools/phpbench/vendor/autoload.php
+        - ./vendor/autoload.php
 
     ignoreErrors:
-        # suppress strange behavior of PHPStan where it considers proxy() return type as *NEVER*
-        - message: '#Return type of call to function Zenstruck\\Foundry\\Persistence\\proxy contains unresolvable type#'
-          path: src/Persistence/ProxyRepositoryDecorator.php
-
         # prevent PHPStan to force to type data providers
         - identifier: missingType.iterableValue
           path: tests/
 
-        # PHPStan does not understand PHP version checks
-        - message: '#Comparison operation "(<|>|<=|>=)" between int<80\d+, 80\d+> and 80\d+ is always (false|true).#'
-
-        # Hydrator and Factory are annotated @immutable
-        - identifier: property.readOnlyByPhpDocDefaultValue
-          paths:
-            - src/Object/Hydrator.php
-            - src/Factory.php
-            - src/ObjectFactory.php
-            - src/Persistence/PersistentObjectFactory.php
-
-        # Hydrator and Factory are annotated @immutable
-        - identifier: property.readOnlyByPhpDocAssignNotInConstructor
-          paths:
-            - src/Object/Hydrator.php
-            - src/Factory.php
-            - src/ObjectFactory.php
-            - src/Persistence/PersistentObjectFactory.php
-
-        # generics annotation are not so helpful in maker code
-        - identifier: missingType.generics
-          path: src/Maker/Factory/
-
-        # not relevant for factories generated by maker
-        - identifier: missingType.callable
-          path: tests/Fixture/Maker/expected/
-
         # not relevant for files outside from Foundry's namespace
         - identifier: classConstant.internalClass
           path: config/
-        - identifier: function.internal
-          path: tests/bootstrap-reset-database.php
 
     excludePaths:
         - config/reference.php (?)
-
-        - tests/Fixture/Maker/expected/can_create_factory_with_auto_activated_not_persisted_option.php
-        - tests/Fixture/Maker/expected/can_create_factory_interactively.php
-        - tests/Fixture/Maker/expected/can_create_factory_with_embeddable_with_data_set_odm.php
-        - tests/Fixture/Maker/expected/can_create_factory_with_embeddable_with_data_set_orm.php
-
-        # phpstan runs with orm 3 - there are too many failures in these files which are compatible with orm 2
-        - ./src/Maker/Factory/LegacyORMDefaultPropertiesGuesser.php
-        - ./src/Maker/Factory/DoctrineScalarFieldsDefaultPropertiesGuesser.php
-        - ./src/ORM/OrmV2PersistenceStrategy.php
-
-        - ./src/Test/Behat/

phpunit-10.xml.dist

@@ -277,7 +277,7 @@ public function build(ContainerBuilder $container): void
         $container->addCompilerPass(new AsFixtureStoryCompilerPass());
 
         if (class_exists(BehatServicesCompilerPass::class)) {
-            $container->addCompilerPass(new BehatServicesCompilerPass());
+            $container->addCompilerPass(new BehatServicesCompilerPass()); // @phpstan-ignore argument.type
         }
     }