Plugin "Locations are empty" error

[Yoavp81]

Hello,

I'm running Valhalla on a local host using a docker image.
Running isochrones (and other routing functions) works for some points but then throws the following error:

Traceback (most recent call last):
File "C:\Users/yoavp/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\valhalla\processing\routing\valhalla\isochrones.py", line 138, in processAlgorithm
for result_feat in results_factory.get_results(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users/yoavp/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\valhalla\core\results_factory.py", line 99, in get_results
result = self.router.request(endpoint, loc, **params)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users/yoavp/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\valhalla\core\router_factory.py", line 75, in request
raise ValhallaError(f"Locations are empty: {locations}")
valhalla.exceptions.ValhallaError: Locations are empty: []

Any idea why this is happenning?

Thanks!

[nilsnolde]

Is this run via UI or from processing algos?

It means there was neither origin nor destination.

If you describe (briefly) what you did to get this error, that'd be great. Might be a bug.

[Yoavp81]

I ran it using the processing algorithms.
I have a point layer (10000 points), for which I want to calculate isochrones. Just ran it for pedestrians using a 10 min. interval, Generalize set to 1, all other options set to default.
It manages to get 1650 isochrones out before it halts. It repeatedly stops at the same point. I though it might be due to a particular, problematic, feature. So I ran on a different layer, but this too results in the same error.

[nilsnolde]

Then smth is probably wrong with the x/y of feature 1650 or 1651. Not the most experienced QGIS user here, but it's probably possible to have an invalid feature in a layer?

[Yoavp81]

Could be, but I can't make certain, since Valhalla has some order in which it processes the features, and I don't think it's either ascending or descending order of the ID field (unless I'm mistaken). So I can't know for sure which feature might be the cause of the problem. It would be helpful, though, that if it encounters such features, it continues with the processing and ignores it, instead of stopping.
I'll do a rigorous check of the features to see if there's something wrong with them.

[Yoavp81]

The following are the features in the layer. When running Valhalla on all features it gives the mentioned error. However, when splitting the layer into 3 separate layers (as pictured below) and running Valhalla on each - no error appears.

[nilsnolde]

Strange observation.. I really have no idea what could be causing this, sorry.. Just realized you mentioned that this is not layer specific. I'll try that myself later with some synthetic dataset.