FR: clone `packages` repo in shallow mode (`--depths=1`)

[ZoomRmc]

atlas/src/basic/gitops.nim

Line 112 in 839c158

elif ShallowClones in context().flags: "--depth=1"

atlas/src/basic/packageinfos.nim

Line 108 in 839c158

let res = clone(parseUri "https://github.com/nim-lang/packages", pkgsDir)

Currently the clone operation is global-configured to use shallow cloning. Atlas needs to pass this option to clone directly or ignore it when cloning the packages repo. In my setup shallow cloning packages brings it down to 1,1M from 5,4M. Considering this is for each project, this is pretty significant.

BTW, is there a reason to keep separate packages clone for each deps directory and not use a global one?

[elcritch]

Currently the clone operation is global-configured to use shallow cloning. Atlas needs to pass this option to clone directly or ignore it when cloning the packages repo. In my setup shallow cloning packages brings it down to 1,1M from 5,4M. Considering this is for each project, this is pretty significant.

Hmmm, yeah that could work. Atlas doesn't need history for packages.

BTW, is there a reason to keep separate packages clone for each deps directory and not use a global one?

Not really other than simplicity and to avoid having "magic state" that's hidden elsewhere. It could be possible to add an option for that.

[elcritch]

This is resolved now by just downloading the packages.json directly from GtiHub. Much faster: e3415c0

[ZoomRmc]

The speed is solved, but not the issue. --packagesRepo still doesn't make a shallow clone.

[elcritch]

The speed is solved, but not the issue. --packagesRepo still doesn't make a shallow clone.

Are not speed and smaller size the main goals of shallow cloning the packages repo?

The --packagesRepo is only left as a backup for environments where regular github/https access might be unavailable or Nim SSL is broken. In those rare cases not sure a shallow clone will gain much. Otherwise it'd be better to just not clone the package repo at all.