Revert "remove unnecessary dup"

This reverts commit 2807e3c.

Author: narimiran

src/nimble.nim

@@ -1480,7 +1480,7 @@ proc validateDevModeDepsWorkingCopiesBeforeLock(
     }
 
   # Remove not errors from the errors set.
-  for name, error in errors:
+  for name, error in common.dup(errors):
     if error.kind in notAnErrorSet:
       errors.del name
 
@@ -1699,7 +1699,7 @@ proc sync(options: Options) =
   var errors: ValidationErrors
   findValidationErrorsOfDevDepsWithLockFile(pkgInfo, options, errors)
 
-  for name, error in errors:
+  for name, error in common.dup(errors):
     if error.kind == vekWorkingCopyNeedsSync:
       if not options.action.listOnly:
         syncWorkingCopy(name, error.path, pkgInfo, options)

src/nimblepkg/common.nim

@@ -52,6 +52,8 @@ template newClone*[T: not ref](obj: T): ref T =
   result[] = obj
   result
 
+proc dup*[T](obj: T): T = obj
+
 proc `$`*(p: ptr | ref): string = cast[int](p).toHex
   ## Converts the pointer `p` to its hex string representation.
 

src/nimblepkg/developfile.nim

@@ -246,9 +246,7 @@ proc addPackage(data: var DevelopFileData, pkgInfo: PackageInfo,
   if pkg == nil:
     # If a package with `pkgInfo.name` is missing add it to the
     # `DevelopFileData` internal data structures add it.
-    {.warning[ProveInit]: off.}
     pkg = pkgInfo.newClone
-    {.warning[ProveInit]: on.}
     data.pkgRefCount.inc(pkg)
     data.nameToPkg[pkg[].basicInfo.name] = pkg
     data.pathToPkg[pkg[].getNimbleFilePath()] = pkg
@@ -387,7 +385,7 @@ proc load(path: Path, dependentPkg: PackageInfo, options: Options,
     # If this is a package develop file, but not a free one, for each of the
     # package's develop mode dependencies load its develop file if it is not
     # already loaded and merge its data to the current develop file's data.
-    for path, pkg in result.pathToPkg:
+    for path, pkg in result.pathToPkg.dup:
       if visitedPkgs.contains(path):
         continue
       var followedPkgDevFileData = initDevelopFileData()