Skip to content

Commit 5d4d8db

Browse files
authored
Only caches nim release for a day (#1326)
1 parent 920793e commit 5d4d8db

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/nimblepkg/downloadnim.nim

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -546,7 +546,10 @@ proc getOfficialReleases*(options: Options): seq[Version] =
546546
let oficialReleasesCachedFile =
547547
options.nimbleDir.absolutePath() / "official-nim-releases.json"
548548
if oficialReleasesCachedFile.fileExists():
549-
return oficialReleasesCachedFile.readFile().parseJson().to(seq[Version])
549+
#We only store the file for a day.
550+
let fileCreation = getTime() - getFileInfo(oficialReleasesCachedFile).lastWriteTime
551+
if fileCreation.inDays <= 1:
552+
return oficialReleasesCachedFile.readFile().parseJson().to(seq[Version])
550553
var parsedContents: JsonNode
551554
try:
552555
let rawContents = retrieveUrl(githubTagReleasesUrl.addGithubAuthentication())

tests/tnimbinaries.nim

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ suite "Nim binaries":
1010
var options = initOptions()
1111
let releases = getOfficialReleases(options)
1212
check releases.len > 0
13-
check releases[^1] == newVersion("1.2.8")
1413

1514
test "can download a concrete version":
1615
var options = initOptions()

0 commit comments

Comments
 (0)