Add package name to no tagged releases warning

Author: MorganaFuture

src/nimblepkg/download.nim

@@ -226,6 +226,25 @@ proc seemsLikeRevision(version: string): bool =
       return false
   return true
 
+proc extractPackageName*(url: string): string =
+  ## Extracts package name from repository URL.
+  ##
+  ## For example:
+  ## "https://github.com/nim-lang/nimble.git" -> "nimble"
+  ## "https://gitlab.com/user/mypackage" -> "mypackage"
+  ## "git://example.com/foo/bar.git" -> "bar"
+  let cleanUrl = removeTrailingGitString(url)
+  let lastSlash = cleanUrl.rfind('/')
+  if lastSlash >= 0 and lastSlash < cleanUrl.len - 1:
+    result = cleanUrl[lastSlash + 1 .. ^1]
+  else:
+    # Fallback to the whole URL if no slash found
+    result = cleanUrl
+  # Remove any remaining extensions like .tar.gz
+  let dotPos = result.find('.')
+  if dotPos > 0:
+    result = result[0 ..< dotPos]
+
 proc extractOwnerAndRepo(url: string): string =
   ## Extracts owner and repository string from an URL to GitHub repository.
   ##
@@ -425,7 +444,8 @@ proc doDownload(url, downloadDir: string, verRange: VersionRange,
             doClone(downMethod, url, downloadDir, latest.tag,
                     onlyTip = not options.forceFullClone, options = options)
       else:
-        display("Warning:", "The package has no tagged releases, downloading HEAD instead.", Warning,
+        let pkgName = extractPackageName(url)
+        display("Warning:", "The package '" & pkgName & "' has no tagged releases, downloading HEAD instead.", Warning,
                 priority = HighPriority)
         if downloadTarball(url, options):
           result.vcsRevision = doDownloadTarball(url, downloadDir, "HEAD", true)
@@ -444,7 +464,8 @@ proc doDownload(url, downloadDir: string, verRange: VersionRange,
                   priority = MediumPriority)
           doCheckout(downMethod, downloadDir, latest.tag, options = options)
       else:
-        display("Warning:", "The package has no tagged releases, downloading HEAD instead.", Warning,
+        let pkgName = extractPackageName(url)
+        display("Warning:", "The package '" & pkgName & "' has no tagged releases, downloading HEAD instead.", Warning,
                   priority = HighPriority)
 
   if result.vcsRevision == notSetSha1Hash:

tests/tdownload.nim

@@ -0,0 +1,65 @@
+# Copyright (C) Dominik Picheta. All rights reserved.
+# BSD License. Look at license.txt for more info.
+
+{.used.}
+
+import unittest
+import nimblepkg/download
+
+suite "download":
+  test "extractPackageName extracts package name from various URL formats":
+    # GitHub URLs
+    check extractPackageName("https://github.com/nim-lang/nimble.git") == "nimble"
+    check extractPackageName("https://github.com/nim-lang/nimble") == "nimble"
+    check extractPackageName("https://github.com/user/repo.git") == "repo"
+    check extractPackageName("https://github.com/organization/package-name") ==
+      "package-name"
+
+    # GitLab URLs
+    check extractPackageName("https://gitlab.com/user/mypackage") == "mypackage"
+    check extractPackageName("https://gitlab.com/group/subgroup/project.git") ==
+      "project"
+
+    # Bitbucket URLs
+    check extractPackageName("https://bitbucket.org/user/repository.git") == "repository"
+    check extractPackageName("https://bitbucket.org/team/project") == "project"
+
+    # Generic git URLs
+    check extractPackageName("git://example.com/foo/bar.git") == "bar"
+    check extractPackageName("git://server.org/path/to/repo.git") == "repo"
+    check extractPackageName("ssh://[email protected]/user/package.git") == "package"
+
+    # HTTP/HTTPS URLs
+    check extractPackageName("http://example.com/repos/mypackage.git") == "mypackage"
+    check extractPackageName("https://custom-git.com/projects/awesome-lib") ==
+      "awesome-lib"
+
+    # Edge cases
+    check extractPackageName("https://github.com/user/repo.tar.gz") == "repo"
+    check extractPackageName("https://example.com/package.bundle") == "package"
+    check extractPackageName("https://server.com/path/to/deeply/nested/package") ==
+      "package"
+
+    # URLs with special characters
+    check extractPackageName("https://github.com/user/my_package-2.git") ==
+      "my_package-2"
+    check extractPackageName("https://gitlab.com/user/package.v2") == "package"
+
+  test "extractPackageName handles edge cases gracefully":
+    # URL without path (returns the domain part)
+    check extractPackageName("https://example.com") == "example"
+
+    # Just a package name (no slashes)
+    check extractPackageName("package") == "package"
+    check extractPackageName("package.git") == "package"
+
+  test "removeTrailingGitString removes .git suffix":
+    check removeTrailingGitString("https://github.com/nim-lang/nimble.git") ==
+      "https://github.com/nim-lang/nimble"
+    check removeTrailingGitString("https://github.com/nim-lang/nimble") ==
+      "https://github.com/nim-lang/nimble"
+    check removeTrailingGitString("repo.git") == "repo"
+    check removeTrailingGitString("git") == "git"
+      # Should not remove if string is too short
+    check removeTrailingGitString(".git") == ".git"
+      # Should not remove if string is exactly .git

tests/tester.nim

@@ -9,6 +9,7 @@ import tinitcommand
 import tcheckcommand
 import tcleancommand
 import tdevelopfeature
+import tdownload
 import tissues
 import tlocaldeps
 import tlockfile