Fixes an issue where special versions wanst being saved on new installs, so they needed to be reinstalled. (#1435)

* Fixes an issue where special versions wanst being saved on new installs, so they needed to be reinstalled.

* adds missing line

Author: jmgomez

src/nimblepkg/vnext.nim

@@ -524,7 +524,7 @@ proc packageExists(pkgInfo: PackageInfo, options: Options):
     return some(oldPkgInfo)
 
 
-proc installFromDirDownloadInfo(downloadDir: string, url: string, options: Options): PackageInfo = 
+proc installFromDirDownloadInfo(downloadDir: string, url: string, pv: PkgTuple, options: Options): PackageInfo = 
 
   let dir = downloadDir
   var pkgInfo = getPkgInfo(dir, options)
@@ -570,6 +570,8 @@ proc installFromDirDownloadInfo(downloadDir: string, url: string, options: Optio
     filesInstalled.incl copyFileD(pkgInfo.myPath, dest)
     pkgInfo.myPath = dest
     pkgInfo.metaData.files = filesInstalled.toSeq
+    if pv.ver.kind == verSpecial:
+      pkgInfo.metadata.specialVersions.incl pv.ver.spe
 
     saveMetaData(pkgInfo.metaData, pkgDestDir)
   else:
@@ -885,7 +887,7 @@ proc installPkgs*(satResult: var SATResult, options: Options) =
         # Check if package already exists before installing
         let tempPkgInfo = getPkgInfo(satResult.rootPackage.getNimbleFileDir(), options)
         let oldPkg = tempPkgInfo.packageExists(options)
-        installedPkgInfo = installFromDirDownloadInfo(satResult.rootPackage.getNimbleFileDir(), satResult.rootPackage.metaData.url, options).toRequiresInfo(options)
+        installedPkgInfo = installFromDirDownloadInfo(satResult.rootPackage.getNimbleFileDir(), satResult.rootPackage.metaData.url, pv, options).toRequiresInfo(options)
         wasNewlyInstalled = oldPkg.isNone
     else:      
       var dlInfo = getPackageDownloadInfo(pv, options, doPrompt = true)
@@ -904,7 +906,7 @@ proc installPkgs*(satResult: var SATResult, options: Options) =
       # Check if package already exists before installing
       let tempPkgInfo = getPkgInfo(downloadDir, options)
       let oldPkg = tempPkgInfo.packageExists(options)
-      installedPkgInfo = installFromDirDownloadInfo(downloadDir, dlInfo.url, options).toRequiresInfo(options)
+      installedPkgInfo = installFromDirDownloadInfo(downloadDir, dlInfo.url, pv, options).toRequiresInfo(options)     
       wasNewlyInstalled = oldPkg.isNone
       if installedPkgInfo.metadata.url == "" and pv.name.isUrl:
         installedPkgInfo.metadata.url = pv.name

tests/trequireflag.nim

@@ -46,8 +46,8 @@ suite "requires flag":
       - json_serialization#4cd31594f868a3d3cb81ec9d5f479efbe2466ebd
   ]#
     let requires = [
-      "https://github.com/status-im/nim-json-serialization.git#nimble_test_dont_delete",
-      "https://github.com/status-im/nim-json-serialization.git#26bea5ffce20ae0d0855b3d61072de04d3bf9826",
+      # "https://github.com/status-im/nim-json-serialization.git#nimble_test_dont_delete",
+      # "https://github.com/status-im/nim-json-serialization.git#26bea5ffce20ae0d0855b3d61072de04d3bf9826",
       "json_serialization#nimble_test_dont_delete",
       "json_serialization#26bea5ffce20ae0d0855b3d61072de04d3bf9826",
       "json_serialization == 0.2.9"