Changes the order of path so the nim in the deps is prioritised (#1333)

* Changes the order of `path` so the `nim` in the deps is prioritized

* fixes test

* removes unused

Author: jmgomez

src/nimble.nim

@@ -2260,7 +2260,7 @@ proc getAlteredPath(options: Options): string =
       paths.add folder
   paths.reverse
   let parentDir = options.nimBin.get.path.parentDir
-  result = fmt "{parentDir}{separator}{paths.join(separator)}{separator}{getEnv(\"PATH\")}"
+  result = fmt "{paths.join(separator)}{separator}{parentDir}{separator}{getEnv(\"PATH\")}"
 
 proc shellenv(options: var Options) =
   setVerbosity(SilentPriority)

tests/tshellenv.nim

@@ -28,11 +28,9 @@ suite "Shell env":
 
       when defined windows:
         check prefix == "set PATH"
-        const extension = ".exe"
       else:
-        const extension = ""
         check prefix == "export PATH"
 
-      check (dirs[0] / ("nim" & extension)).fileExists
-      check dirs[1].extractFileName == "shellenv"
-      check dirs[2].extractFileName == "testutils-0.5.0-756d0757c4dd06a068f9d38c7f238576ba5ee897"
+
+      check dirs[0].extractFileName == "shellenv"
+      check dirs[1].extractFileName == "testutils-0.5.0-756d0757c4dd06a068f9d38c7f238576ba5ee897"