Feature/#331 formatting of codeblock comments in search breaks #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When highlighting text with "*" in markdown, it needs space between the hit enshrined by "**" to get boldened. This is not always the case. Therefore we add whitespaces before/after the ** This way we can enforce that it properly gets boldened. nim-lang#331
Sometimes search-results contain the string `## `. They do occur as code comments in code-blocks. If they get recognized, they get turned into headlines. To avoid this, a replace statement was added. nim-lang#331
Sometimes search-results contain the string `[`. They do occur as generics in code-blocks. If they get recognized, they get turned into links. To avoid this, a replace statement was added. nim-lang#331
|
As discussed in #331, please consider removing text formatting altogether. This change somewhat fixes code rendering, but breaks normal markdown rendering. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #331
Fixes overall 2 issues:
##,#and the like often get rendered into headlines under the right circumstances. By replacing them with\#(which most of the time get rendered to#instead of\#) you can prevent this from the get-goSearch-hits sometimes get incorrectly boldened. As in, you get rendered
**blabla**NoWhitespaceHere, which will lead to the stars being rendered instead of them turning bold. By enforcing in the SQL that "post-snippet" it'll add**instead of just stars, you can prevent this problem from the start.also takes care of some HTML rendering problems:
Broken example:
-Whitespacing is generally broken
## [ ( )*] rshould actually contain this HTML string:## [<p1> (<p2> <p1>)*]Now with the fixes applied:
