Skip to content

Don't include deleted posts in rss feed and make the feeds discoverable #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Don't include deleted posts in rss feed and make the feeds discoverable #371

wants to merge 3 commits into from

Conversation

@SirOlaf
Copy link

@SirOlaf SirOlaf commented Aug 23, 2024 •
edited
Loading

All of the drug spam is included in the rss feeds, huge amount of noise

@SirOlaf SirOlaf marked this pull request as draft August 23, 2024 09:16
@SirOlaf SirOlaf marked this pull request as ready for review August 23, 2024 09:34
@SirOlaf SirOlaf changed the title Don't include deleted posts in rss feed Don't include deleted posts in rss feed and make the feeds discoverable Aug 23, 2024
@PMunch
Copy link
Collaborator

PMunch commented Sep 2, 2024

Typically we will set the creator of these topics rank to Spammer but not delete the topics themselves. So for this to be more effective it should check whether the author of a topic has a valid rank as well.

@SirOlaf
Copy link
Author

SirOlaf commented Sep 2, 2024

Thanks for the explanation, looks like both Spammer and Troll are filtered out

@PMunch
Copy link
Collaborator

PMunch commented Sep 2, 2024

Hmm, where do you see that?

@SirOlaf
Copy link
Author

SirOlaf commented Sep 2, 2024 •
edited
Loading

nimforum/src/forum.nim

Line 872 in 719c5c6

u.status <> 'Spammer' and u.status <> 'Troll' and
trying to figure out the correct way to do it currently. Frontend goes further and filters anything <= Moderated if the user is not a Moderator or above

nimforum/src/frontend/threadlist.nim

Line 226 in 719c5c6

if not visibleTo(thread, currentUser): continue

nimforum/src/frontend/threadlist.nim

Line 27 in 719c5c6

thread.author.rank <= Moderated

@SirOlaf
Copy link
Author

SirOlaf commented Sep 2, 2024

As there is no frontend for rss maybe it should all be filtered out during the query?

@PMunch
Copy link
Collaborator

PMunch commented Mar 20, 2025

As there is no frontend for rss maybe it should all be filtered out during the query?

Not quite sure what you mean by this

@PMunch
Copy link
Collaborator

PMunch commented Jun 2, 2025

Did you ever finish this up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SirOlaf @PMunch