fix inner ref object not semchecking in bodies phase (#1182)

fixes #1180

Type decls only get semchecked if either:

* semchecking is in the signature phase
* semchecking is in any phase except toplevelsyms and the type does not
have a symbol yet/is from generics/templates

Since inner ref objects already have a symbol and the `block` only
semchecks at the bodies phase, we need to run the signature phase again
here so that the inner object type is semchecked.

Author: metagn

src/nimony/semdecls.nim

@@ -814,7 +814,7 @@ proc semTypeSection(c: var SemContext; n: var Cursor) =
     swap c.dest, c.pending
 
   if isRefPtrObj:
-    if c.phase != SemcheckTopLevelSyms:
+    if c.phase > SemcheckTopLevelSyms:
       var topLevelDest = createTokenBuf(64)
       var topLevelRead = beginRead(innerObjDecl)
       var phase = SemcheckTopLevelSyms
@@ -824,6 +824,17 @@ proc semTypeSection(c: var SemContext; n: var Cursor) =
       swap c.dest, topLevelDest
       swap c.phase, phase
       innerObjDecl = topLevelDest
+    if c.phase > SemcheckSignatures:
+      # need to go through signature phase if not applied yet since decl already has sym 
+      var sigDest = createTokenBuf(64)
+      var sigRead = beginRead(innerObjDecl)
+      var phase = SemcheckSignatures
+      swap c.phase, phase
+      swap c.dest, sigDest
+      semTypeSection c, sigRead
+      swap c.dest, sigDest
+      swap c.phase, phase
+      innerObjDecl = sigDest
     var decl = beginRead(innerObjDecl)
     semTypeSection c, decl
 

tests/nimony/types/tscopedtype.nif

@@ -0,0 +1,20 @@
+(.nif24)
+0,1,tests/nimony/types/tscopedtype.nim(stmts ,2
+ (block . 2,1
+  (stmts 6,1
+   (type ~4 :Foo.0.tsca4az8i1 . . . 2
+    (ref 4 Foo.Obj.0.tsca4az8i1)) 6,1
+   (type ~4 :Foo.Obj.0.tsca4az8i1 . . . 6
+    (object 10 RootObj.0.sysvq0asl ~8,1
+     (fld :id.0.tsca4az8i1 . . 4
+      (i -1) .))) 4,4
+   (var :s.0 . . 4,~3
+    (ref 4 Foo.Obj.0.tsca4az8i1) 7
+    (newobj ~3,~3
+     (ref 4 Foo.Obj.0.tsca4az8i1) 3
+     (kv ~2 id.0.tsca4az8i1 2 +12))) 2,116,lib/std/syncio.nim
+   (stmts 2,1
+    (stmts
+     (cmd write.2.syn1lfpjv 6 stdout.0.syn1lfpjv 8,9,tests/nimony/types/tscopedtype.nim
+      (ddot ~1 s.0 id.0.tsca4az8i1 +0))) ,2
+    (cmd write.5.syn1lfpjv 6 stdout.0.syn1lfpjv 14 '\0A')))))

tests/nimony/types/tscopedtype.nim

@@ -0,0 +1,9 @@
+import std/syncio
+
+block:
+  type
+    Foo = ref object of RootObj
+      id: int
+
+  var s = Foo(id: 12)
+  echo s.id

tests/nimony/types/tscopedtype.output

@@ -0,0 +1 @@
+12