replaces raiseAssert with bugs in nimony + hexer (#1091)

ref #1066

Author: ringabout

src/hexer/constparams.nim

@@ -301,7 +301,7 @@ proc trPragmaBlock(c: var Context; dest: var TokenBuf; n: var Cursor) =
     tr(c, dest, n)
     c.keepOverflowFlag = oldKeepOverflowFlag
   else:
-    raiseAssert "unknown pragma block: " & toString(n, false)
+    bug "unknown pragma block: " & toString(n, false)
   skipParRi n # pragmax
 
 proc checkedArithOp(c: var Context; dest: var TokenBuf; n: var Cursor) =

src/hexer/destroyer.nim

@@ -152,7 +152,7 @@ proc leaveNamedBlock(c: var Context; label: SymId) =
   if it != nil and it.label == label:
     leaveScope(c, it[])
   else:
-    raiseAssert "do not know which block to leave"
+    bug "do not know which block to leave"
 
 proc leaveAnonBlock(c: var Context) =
   var it = addr(c.currentScope)
@@ -162,7 +162,7 @@ proc leaveAnonBlock(c: var Context) =
   if it != nil and it.kind == WhileOrBlock:
     leaveScope(c, it[])
   else:
-    raiseAssert "do not know which block to leave"
+    bug "do not know which block to leave"
 
 proc trBreak(c: var Context; n: var Cursor) =
   let lab = n.firstSon

src/hexer/desugar.nim

@@ -65,7 +65,7 @@ proc skipParRi(n: var Cursor) =
   if n.kind == ParRi:
     inc n
   else:
-    error "expected ')', but got: ", n
+    bug "expected ')', but got: ", n
 
 proc tr(c: var Context; dest: var TokenBuf; n: var Cursor)
 
@@ -318,7 +318,7 @@ proc genSetOp(c: var Context; dest: var TokenBuf; n: var Cursor) =
               dest.addUIntLit(uint64(mask), info)
         dest.addUIntLit(0, info)
     else:
-      raiseAssert("unreachable")
+      bug("unreachable")
   else:
     case kind
     of LtSetX, LeSetX:
@@ -387,7 +387,7 @@ proc genSetOp(c: var Context; dest: var TokenBuf; n: var Cursor) =
             of PlusSetX: BitorX
             of XorSetX: BitxorX
             of MulSetX, MinusSetX: BitandX
-            else: raiseAssert("unreachable")
+            else: bug("unreachable")
           addUIntTypedOp dest, op, 8, info:
             copyIntoKind dest, ArrAtX, info:
               dest.addSubtree a
@@ -418,7 +418,7 @@ proc genSetOp(c: var Context; dest: var TokenBuf; n: var Cursor) =
               dest.addUIntLit(7, info)
         dest.addUIntLit(0, info)
     else:
-      raiseAssert("unreachable")
+      bug("unreachable")
   if useTemp:
     dest.addParRi()
     c.tempUseBufStack.shrink(oldBufStackLen)
@@ -767,7 +767,7 @@ proc tr(c: var Context; dest: var TokenBuf; n: var Cursor) =
     else:
       trSons(c, dest, n)
   of ParRi:
-    raiseAssert "unexpected ')' inside"
+    bug "unexpected ')' inside"
 
 proc desugar*(n: Cursor; moduleSuffix: string; activeChecks: set[CheckMode]): TokenBuf =
   var c = Context(counter: 0, typeCache: createTypeCache(), thisModuleSuffix: moduleSuffix, activeChecks: activeChecks)

src/hexer/duplifier.nim

@@ -927,9 +927,9 @@ proc tr(c: var Context; n: var Cursor; e: Expects) =
     of DerefX, HderefX:
       trDeref c, n
     of DdotX:
-      raiseAssert "nodekind should have been eliminated in desugar.nim"
+      bug "nodekind should have been eliminated in desugar.nim"
     of DefaultobjX, DefaulttupX, BracketX, CurlyX, TupX:
-      raiseAssert "nodekind should have been eliminated in sem.nim"
+      bug "nodekind should have been eliminated in sem.nim"
     of PragmaxX, CurlyatX, TabconstrX, DoX, FailedX:
       trSons c, n, e
     of NoExpr:

src/hexer/inliner.nim

@@ -157,7 +157,7 @@ proc inlineRoutineBody(c: var InlineContext; dest: var TokenBuf; n: var Cursor)
     dest.add n
     inc n
   of ParRi:
-    raiseAssert "unhandled ')' in inliner.nim"
+    bug "unhandled ')' in inliner.nim"
   of ParLe:
     case n.stmtKind
     of RetS:

src/hexer/lifter.nim

@@ -141,7 +141,7 @@ proc isTrivial*(c: var LiftingCtx; typ: TypeCursor): bool =
     result = true
   of NoType, ErrT, NiltT, OrT, AndT, NotT, ConceptT, DistinctT, StaticT, InvokeT,
      TypeKindT, UntypedT, TypedT, IteratorT, ItertypeT:
-    raiseAssert "bug here"
+    bug "bug here"
 
 # Phase 2: Do the lifting
 
@@ -220,7 +220,7 @@ proc lift(c: var LiftingCtx; typ: TypeCursor): SymId =
   let typ = toTypeImpl typ
   case typ.typeKind
   of PtrT:
-    raiseAssert "ptr T should have been a 'trivial' type"
+    bug "ptr T should have been a 'trivial' type"
   of ObjectT, DistinctT, TupleT, ArrayT, RefT:
     result = requestLifting(c, c.op, orig)
   else:

src/hexer/mover.nim

@@ -150,7 +150,7 @@ proc singlePath(pc: Cursor; nested: int; x: Cursor; pcs: var seq[Cursor]; otherU
         pc = pc +! diff
     of ParRi:
       if nested == 0:
-        raiseAssert "BUG: unpaired ')'"
+        bug "unpaired ')'"
       dec nested
       inc pc
     of Symbol:
@@ -219,7 +219,7 @@ proc singlePath(pc: Cursor; nested: int; x: Cursor; pcs: var seq[Cursor]; otherU
            IncludeS, ImportS, FromimportS, ImportExceptS, CommentS, PragmasS,
            ImportasS, ExportexceptS, BindS, MixinS, UsingS,
            UnpackDeclS, StaticstmtS, AsmS, DeferS:
-          raiseAssert "BUG: statement not eliminated: " & $pc.stmtKind
+          bug "statement not eliminated: " & $pc.stmtKind
         of ProcS, FuncS, IteratorS, ConverterS, MethodS, MacroS, TemplateS, TypeS,
            AssumeS, AssertS:
           # declarative junk we don't care about:
@@ -283,7 +283,7 @@ when isMainModule:
         discard
       if nested == 0: break
       inc result
-    raiseAssert "BUG: no 'ensureMove' found"
+    bug "no 'ensureMove' found"
 
   proc test(s: string; expected: bool) =
     var input = parse(s)

src/hexer/nifcgen.nim

@@ -716,7 +716,7 @@ proc parsePragmas(c: var EContext; n: var Cursor): CollectedPragmas =
           skip n
           continue
         of BuildP, EmitP:
-          raiseAssert "unreachable"
+          bug "unreachable"
         skipParRi c, n
       else:
         error c, "unknown pragma: ", n

src/hexer/stringcases.nim

@@ -52,7 +52,7 @@ proc getSimpleStringLit(c: var EContext; n: var Cursor): StrId =
       result = getSimpleStringLit(c, inlineValue)
       inc n
     else:
-      raiseAssert "not a string literal"
+      bug "not a string literal"
   else:
     case n.exprKind:
     of SufX:
@@ -67,7 +67,7 @@ proc getSimpleStringLit(c: var EContext; n: var Cursor): StrId =
       result = getSimpleStringLit(c, n)
       skipParRi n
     else:
-      raiseAssert "not a string literal"
+      bug "not a string literal"
 
 proc transformStringCase*(c: var EContext; n: var Cursor) =
   c.demand pool.syms.getOrIncl("equalStrings.0." & SystemModuleSuffix)

src/hexer/xelim.nim

@@ -452,7 +452,7 @@ proc trExpr(c: var Context; dest: var TokenBuf; n: var Cursor; tar: var Target)
           while n.kind != ParRi:
             trExpr c, dest, n, tar
   of ParRi:
-    raiseAssert "unexpected ')' inside"
+    bug "unexpected ')' inside"
 
 proc lowerExprs*(n: Cursor; moduleSuffix: string): TokenBuf =
   var c = Context(counter: 0, typeCache: createTypeCache(), thisModuleSuffix: moduleSuffix)