feat: allow multiple api hosts (#55)

Do not assume a host in redirects.
Retrieve host for token.
Add tests.

Author: rabbah

src/index.js

@@ -92,9 +92,20 @@ module.exports = {
       }
     } else {
       try {
-        await utils.run.command(
-          `nim auth login ${process.env.NIMBELLA_LOGIN_TOKEN}`
-        )
+        if (
+          process.env.NIMBELLA_API_HOST &&
+          process.env.NIMBELLA_API_HOST !== ''
+        ) {
+          await utils.run.command(
+            `nim auth login ${process.env.NIMBELLA_LOGIN_TOKEN} --apihost ${process.env.NIMBELLA_API_HOST}`
+          )
+        } else {
+          // Delegate to default apihost configured in the cli.
+          await utils.run.command(
+            `nim auth login ${process.env.NIMBELLA_LOGIN_TOKEN}`
+          )
+        }
+
         // Cache the nimbella config to avoid logging in for consecutive builds.
         await utils.cache.save(nimConfig)
       } catch (error) {
@@ -172,6 +183,10 @@ module.exports = {
     const redirectRules = []
     const redirects = []
     const redirectsFile = join(constants.PUBLISH_DIR, '_redirects')
+    let {stdout: apihost} = await utils.run.command(
+      `nim auth current --apihost`
+    )
+    apihost = apihost.replace(/^(https:\/\/)/, '')
 
     if (isActions) {
       if (existsSync(redirectsFile)) {
@@ -198,7 +213,7 @@ module.exports = {
         ) {
           const redirectPath = redirect.to.split('/.netlify/functions/')[1]
           redirectRules.push(
-            `${redirect.from} https://apigcp.nimbella.io/api/v1/web/${namespace}/default/${redirectPath} 200!`
+            `${redirect.from} https://${apihost}/api/v1/web/${namespace}/default/${redirectPath} 200!`
           )
         }
       }
@@ -211,13 +226,13 @@ module.exports = {
 
     if (isProject) {
       redirectRules.push(
-        `${redirectPath}* https://apigcp.nimbella.io/api/v1/web/${namespace}/:splat 200!`
+        `${redirectPath}* https://${apihost}/api/v1/web/${namespace}/:splat 200!`
       )
     }
 
     if (isActions && !isProject) {
       redirectRules.push(
-        `${redirectPath}* https://apigcp.nimbella.io/api/v1/web/${namespace}/default/:splat 200!`
+        `${redirectPath}* https://${apihost}/api/v1/web/${namespace}/default/:splat 200!`
       )
     }
 

test/index.js

@@ -1,5 +1,6 @@
 const path = require('path')
 
+const fs = require('fs')
 const mockFs = require('mock-fs')
 const build = require('netlify-lambda/lib/build')
 
@@ -33,6 +34,51 @@ afterEach(() => {
 })
 
 describe('preBuild()', () => {
+  test('Login to default api host', async () => {
+    // Prepare
+    process.env.NIMBELLA_LOGIN_TOKEN = 'somevalue'
+    delete process.env.NIMBELLA_API_HOST
+    utils.cache.has.mockResolvedValue(false)
+
+    const mockFiles = {
+      [require('os').homedir()]: {}
+    }
+    mockFs(mockFiles)
+    await plugin.onPreBuild({
+      utils,
+      constants: {},
+      inputs: {}
+    })
+    mockFs.restore()
+
+    expect(utils.run.command.mock.calls[0][0]).toEqual(
+      `nim auth login somevalue`
+    )
+  })
+
+  test('Login to specified api host', async () => {
+    // Prepare
+    process.env.NIMBELLA_LOGIN_TOKEN = 'somevalue'
+    process.env.NIMBELLA_API_HOST = 'somehost'
+    utils.cache.has.mockResolvedValue(false)
+
+    const mockFiles = {
+      [require('os').homedir()]: {}
+    }
+
+    mockFs(mockFiles)
+    await plugin.onPreBuild({
+      utils,
+      constants: {},
+      inputs: {}
+    })
+    mockFs.restore()
+
+    expect(utils.run.command.mock.calls[0][0]).toEqual(
+      `nim auth login somevalue --apihost somehost`
+    )
+  })
+
   test('show token not available message when login token not set', async () => {
     // Prepare
     process.env.NIMBELLA_LOGIN_TOKEN = ''
@@ -173,9 +219,12 @@ describe('onPostBuild()', () => {
   test('should rewrite existing redirects to .netlify/functions/ in netlify.toml if functions are used', async () => {
     process.env.NIMBELLA_LOGIN_TOKEN = 'somevalue'
     process.env.CONTEXT = 'production'
-    utils.run.command.mockReturnValue({
-      stdout: 'namespace'
+    utils.run.command = jest.fn((cmd) => {
+      if (cmd === 'nim auth current') return {stdout: 'namespace'}
+      if (cmd === 'nim auth current --apihost') return {stdout: 'somehost'}
+      return {stdout: '???'}
     })
+
     const pluginInputs = {
       utils,
       constants: {CONFIG_PATH: 'netlify.toml', PUBLISH_DIR: ''},
@@ -199,9 +248,15 @@ describe('onPostBuild()', () => {
     })
     await plugin.onPreBuild(pluginInputs)
     await plugin.onPostBuild(pluginInputs)
+    const redirects = String(fs.readFileSync('_redirects'))
     mockFs.restore()
+
     expect(console.log.mock.calls[1][0]).toEqual(
       "Found redirect rules in netlify.toml. We will rewrite rules that redirect (200 rewrites) to '/.netlify/functions/*'."
     )
+
+    expect(redirects).toEqual(
+      '/* https://somehost/api/v1/web/namespace/default/:splat 200!'
+    )
   })
 })