modify lookup of nimble package functions in model building and in compilation for nimble-using packages with import not depends

[paciorek]

It looks like we can add nimble:: for getNimbleOption (which is what came up in the user post) as well as nimSwitch,messageIfVerbose,nimbleUserNamespace,nimbleInternalFunctions,waicDetailsNimbleList,waicNimbleList,is.nf. This will need to be done in nimbleModel and some other places I need to investigate, as the items above starting with nimbleUserNamespace popped up when trying to run compileNimble.

However, this will not fully address issue #1304 in that lookup will still fail for model nodeFunctions.

So I guess it is somewhat of an open question whether to do this. I'm inclined to do it as it will be easy to do and might in some cases allow dependent packages to avoid Depends (e.g., if the dependent package builds the model for the user, presumably with calculate=FALSE, and never calls uncompiled nodeFunctions).

@perrydv @danielturek thoughts?

[perrydv]

@paciorek I agree it doesn't hurt and could help. I guess the difficulty with node functions is they have to go through the compiler (which I think won't handle the extra "nimble::"). I remember this was all somewhat unusual in that nimble generates class definitions on the fly, but I don't remember much more insight on the problem.

[paciorek]

@perrydv yes, exactly.

It's something we should keep in mind for nCompiler. I'm not sure if we have a running list of such things that we'd like to address but are not the top-line items that nCompiler is improving.

[paciorek]

Well, even with some additions of nimble::, it's now failing at the stage of compiling an MCMC.

Error in resolveOneUnknownType(compileInfo$returnSymbol, c(neededRCfuns,  : 
  Can't figure out what waicNimbleList is.

We can't have returnType(nimble::waicNimbleList), so I don't see a way around this.

I guess I will commit and push the additional namespace resolution I did add, but leave it at that.

[paciorek]

Well, for now I've decided to leave this as is, at the very least to not further complicate the release.