Updates the version names inside the project #431
toby-thanathip
started this conversation in
RFCs
Replies: 3 comments 1 reply
-
Voted 🚀 |
Beta Was this translation helpful? Give feedback.
0 replies
-
Shall we set |
Beta Was this translation helpful? Give feedback.
1 reply
-
Voted |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Related to: #313 (comment)
As of now, we define the version names differently:
template-xml
&template-compose
→ANDROID_VERSION_NAME = "1.0.0"
sample-xml
&sample-compose
→ANDROID_VERSION_NAME = "3.18.0"
version.properties
→templateScriptVersion=3.18.0
I would like to suggest, to make the following changes:
template-xml
&template-compose
→ANDROID_VERSION_NAME = "1.0.0"
sample-xml
&sample-compose
→ANDROID_VERSION_NAME = "1.0.0"
version.properties
→templateVersion=3.18.0
So the changes are as follows:
1.0.0
forANDROID_VERSION_NAME
, because there's no value in incrementing ittemplateScriptVersion
totemplateVersion
, because the naming makes more senseAs a result, we only need to update the version in one file (when triggering
bump_version.yml
) 🚀6 votes ·
Beta Was this translation helpful? Give feedback.
All reactions