-
Notifications
You must be signed in to change notification settings - Fork 27
Revise .cicdtemplate for Github Actions #539
Copy link
Copy link
Open
Description
Why
There are some points to revamp the current CI/CD template to have workflow ready to work in new projects:
https://github.com/nimblehq/android-templates/tree/develop/.cicdtemplate/.github
- Remove unused templates since it's out of date and unmaintained, the team need to reference to git-template as single source truth and latest update for new projects:
- Combine reviewing PR workflows:
review_pull_request.yml&&run_detekt_and_unit_tests.yml. Both workflow have the same steps can be extract to shared workflow to reuse (Reference: https://docs.github.com/en/actions/using-workflows/sharing-workflows-secrets-and-runners-with-your-organization).
- Revamp the deployment workflow:
deploy_staging_and_production_to_firebase_app_distribution.yml. Github supports environment for deployment therefore creating variables/secretes with environment suffix is unnecessary (Reference: https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment)
Who Benefits?
Developers
Reactions are currently unavailable


