[#286] Fix: Terraform plan can't be applied because of VPC endpoint misconfiguration (#309)

Co-authored-by: Hoang Mirs <hoang.mirs@gmail.com>

Author: Nihisil

.github/wiki/assets/images/architecture/diagram-complete.svg

@@ -20,7 +20,6 @@ const vpcModuleContent = dedent`
     source = "../modules/vpc"
 
     env_namespace = local.env_namespace
-    region        = var.region
   }`;
 
 const applyAwsVpc = async (options: AwsOptions) => {

src/generators/addons/aws/modules/core/vpc.ts

@@ -15,22 +15,3 @@ module "vpc" {
   one_nat_gateway_per_az = false
   enable_dns_hostnames   = true
 }
-
-data "aws_route_tables" "private_route_table" {
-  vpc_id = module.vpc.vpc_id
-
-  filter {
-    name   = "tag:Name"
-    values = ["${var.env_namespace}-vpc-private"]
-  }
-}
-
-resource "aws_vpc_endpoint" "logs" {
-  vpc_id          = module.vpc.vpc_id
-  service_name    = "com.amazonaws.${var.region}.logs"
-  route_table_ids = data.aws_route_tables.private_route_table.ids
-
-  tags = {
-    Name = "${var.env_namespace}-vpc-endpoint-logs"
-  }
-}

templates/addons/aws/modules/vpc/main.tf

@@ -2,8 +2,3 @@ variable "env_namespace" {
   description = "The namespace with environment for the VPCs, used as the prefix for the VPC names, e.g. acme-web-staging"
   type        = string
 }
-
-variable "region" {
-  description = "AWS region"
-  type        = string
-}