mini-apps: add TS setup for local @trustwallet/web3-provider-nimiq types#173
Merged
ines-toupeira merged 4 commits intomainfrom Mar 18, 2026
Merged
mini-apps: add TS setup for local @trustwallet/web3-provider-nimiq types#173ines-toupeira merged 4 commits intomainfrom
ines-toupeira merged 4 commits intomainfrom
Conversation
✅ Deploy Preview for developer-center ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
developer-center-dev-worker | 988216b | Mar 18 2026, 03:40 PM |
Eligioo
reviewed
Mar 16, 2026
Member
Eligioo
left a comment
Eligioo
left a comment
There was a problem hiding this comment.
I think the general gist of this review is that we need to wait a bit until the types package is released. It will get rid of all the Trustwallet references, no need for local checkout, and we it will be under the NPM @nimiq org.
Albermonte
requested changes
Mar 18, 2026
Albermonte
requested changes
Mar 18, 2026
Albermonte
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.