feat: add backup schedule for shared databases

Author: skyfox14

create/mysqldatabase.go

@@ -17,9 +17,10 @@ import (
 
 type mysqlDatabaseCmd struct {
 	resourceCmd
-	Location             meta.LocationName    `placeholder:"${mysqldatabase_location_default}" help:"Where the MySQL database is created. Available locations are: ${mysqldatabase_location_options}"`
-	MysqlDatabaseVersion storage.MySQLVersion `placeholder:"${mysqldatabase_version_default}" help:"Version of the MySQL database. Available versions: ${mysqldatabase_versions}"`
-	CharacterSet         string               `placeholder:"${mysqldatabase_characterset_default}" help:"Character set for the MySQL database. Available character sets: ${mysqldatabase_characterset_options}"`
+	Location             meta.LocationName                      `placeholder:"${mysqldatabase_location_default}" help:"Where the MySQL database is created. Available locations are: ${mysqldatabase_location_options}"`
+	MysqlDatabaseVersion storage.MySQLVersion                   `placeholder:"${mysqldatabase_version_default}" help:"Version of the MySQL database. Available versions: ${mysqldatabase_versions}"`
+	CharacterSet         string                                 `placeholder:"${mysqldatabase_characterset_default}" help:"Character set for the MySQL database. Available character sets: ${mysqldatabase_characterset_options}"`
+	BackupSchedule       storage.DatabaseBackupScheduleCalendar `placeholder:"${mysqldatabase_backupschedule_default}" help:"Backup schedule for the MySQL database. Available schedules: ${mysqldatabase_backupschedule_options}"`
 }
 
 func (cmd *mysqlDatabaseCmd) Run(ctx context.Context, client *api.Client) error {
@@ -76,6 +77,7 @@ func (cmd *mysqlDatabaseCmd) newMySQLDatabase(namespace string) *storage.MySQLDa
 				CharacterSet: storage.MySQLCharacterSet{
 					Name: cmd.CharacterSet,
 				},
+				BackupSchedule: cmd.BackupSchedule,
 			},
 		},
 	}
@@ -93,6 +95,8 @@ func MySQLDatabaseKongVars() kong.Vars {
 	result["mysqldatabase_versions"] = strings.Join(stringSlice(storage.MySQLDatabaseVersions), ", ")
 	result["mysqldatabase_characterset_default"] = "utf8mb4"
 	result["mysqldatabase_characterset_options"] = strings.Join([]string{"utf8mb4"}, ", ")
+	result["mysqldatabase_backupschedule_default"] = string(storage.DatabaseBackupScheduleCalendarDaily)
+	result["mysqldatabase_backupschedule_options"] = strings.Join(stringSlice(storage.DatabaseBackupScheduleCalendars), ", ")
 
 	return result
 }

create/postgresdatabase.go

@@ -17,8 +17,9 @@ import (
 
 type postgresDatabaseCmd struct {
 	resourceCmd
-	Location                meta.LocationName       `placeholder:"${postgresdatabase_location_default}" help:"Where the PostgreSQL database is created. Available locations are: ${postgresdatabase_location_options}"`
-	PostgresDatabaseVersion storage.PostgresVersion `placeholder:"${postgresdatabase_version_default}" help:"Release version with which the PostgreSQL database is created. Available versions: ${postgresdatabase_versions}"`
+	Location                meta.LocationName                      `placeholder:"${postgresdatabase_location_default}" help:"Where the PostgreSQL database is created. Available locations are: ${postgresdatabase_location_options}"`
+	PostgresDatabaseVersion storage.PostgresVersion                `placeholder:"${postgresdatabase_version_default}" help:"Release version with which the PostgreSQL database is created. Available versions: ${postgresdatabase_versions}"`
+	BackupSchedule          storage.DatabaseBackupScheduleCalendar `placeholder:"${postgresdatabase_backupschedule_default}" help:"Backup schedule for the PostgreSQL database. Available schedules: ${postgresdatabase_backupschedule_options}"`
 }
 
 func (cmd *postgresDatabaseCmd) Run(ctx context.Context, client *api.Client) error {
@@ -73,8 +74,9 @@ func (cmd *postgresDatabaseCmd) newPostgresDatabase(namespace string) *storage.P
 				},
 			},
 			ForProvider: storage.PostgresDatabaseParameters{
-				Location: cmd.Location,
-				Version:  cmd.PostgresDatabaseVersion,
+				Location:       cmd.Location,
+				Version:        cmd.PostgresDatabaseVersion,
+				BackupSchedule: cmd.BackupSchedule,
 			},
 		},
 	}
@@ -90,6 +92,8 @@ func PostgresDatabaseKongVars() kong.Vars {
 	result["postgresdatabase_location_options"] = strings.Join(stringSlice(storage.PostgresDatabaseLocationOptions), ", ")
 	result["postgresdatabase_version_default"] = string(storage.PostgresDatabaseVersionDefault)
 	result["postgresdatabase_versions"] = strings.Join(stringSlice(storage.PostgresDatabaseVersions), ", ")
+	result["postgresdatabase_backupschedule_default"] = string(storage.DatabaseBackupScheduleCalendarDaily)
+	result["postgresdatabase_backupschedule_options"] = strings.Join(stringSlice(storage.DatabaseBackupScheduleCalendars), ", ")
 
 	return result
 }

update/mysqldatabase.go

@@ -12,6 +12,7 @@ import (
 
 type mysqlDatabaseCmd struct {
 	resourceCmd
+	BackupSchedule *storage.DatabaseBackupScheduleCalendar `help:"Backup schedule for the MySQL database. Available schedules: ${mysqldatabase_backupschedule_options}"`
 }
 
 func (cmd *mysqlDatabaseCmd) Run(ctx context.Context, client *api.Client) error {
@@ -35,6 +36,8 @@ func (cmd *mysqlDatabaseCmd) Run(ctx context.Context, client *api.Client) error
 	return upd.Update(ctx)
 }
 
-func (cmd *mysqlDatabaseCmd) applyUpdates(_ *storage.MySQLDatabase) {
-	cmd.Warningf("there are no attributes for mysqldatabase which can be updated after creation. Applying update without any changes.")
+func (cmd *mysqlDatabaseCmd) applyUpdates(db *storage.MySQLDatabase) {
+	if cmd.BackupSchedule != nil {
+		db.Spec.ForProvider.BackupSchedule = *cmd.BackupSchedule
+	}
 }

update/mysqldatabase_test.go

@@ -10,6 +10,7 @@ import (
 	"github.com/ninech/nctl/api"
 	"github.com/ninech/nctl/internal/format"
 	"github.com/ninech/nctl/internal/test"
+	"k8s.io/utils/ptr"
 )
 
 func TestMySQLDatabase(t *testing.T) {
@@ -30,6 +31,12 @@ func TestMySQLDatabase(t *testing.T) {
 			update:  mysqlDatabaseCmd{},
 			wantErr: false,
 		},
+		{
+			name:   "update-backup-schedule",
+			create: storage.MySQLDatabaseParameters{BackupSchedule: storage.DatabaseBackupScheduleCalendarDaily},
+			update: mysqlDatabaseCmd{BackupSchedule: ptr.To(storage.DatabaseBackupScheduleCalendarDisabled)},
+			want:   storage.MySQLDatabaseParameters{BackupSchedule: storage.DatabaseBackupScheduleCalendarDisabled},
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {

update/postgresdatabase.go

@@ -12,6 +12,7 @@ import (
 
 type postgresDatabaseCmd struct {
 	resourceCmd
+	BackupSchedule *storage.DatabaseBackupScheduleCalendar `help:"Backup schedule for the PostgreSQL database. Available schedules: ${postgresdatabase_backupschedule_options}"`
 }
 
 func (cmd *postgresDatabaseCmd) Run(ctx context.Context, client *api.Client) error {
@@ -35,6 +36,8 @@ func (cmd *postgresDatabaseCmd) Run(ctx context.Context, client *api.Client) err
 	return upd.Update(ctx)
 }
 
-func (cmd *postgresDatabaseCmd) applyUpdates(_ *storage.PostgresDatabase) {
-	cmd.Warningf("there are no attributes for postgresdatabase which can be updated after creation. Applying update without any changes.")
+func (cmd *postgresDatabaseCmd) applyUpdates(db *storage.PostgresDatabase) {
+	if cmd.BackupSchedule != nil {
+		db.Spec.ForProvider.BackupSchedule = *cmd.BackupSchedule
+	}
 }

update/postgresdatabase_test.go

@@ -10,6 +10,7 @@ import (
 	"github.com/ninech/nctl/api"
 	"github.com/ninech/nctl/internal/format"
 	"github.com/ninech/nctl/internal/test"
+	"k8s.io/utils/ptr"
 )
 
 func TestPostgresDatabase(t *testing.T) {
@@ -30,6 +31,12 @@ func TestPostgresDatabase(t *testing.T) {
 			update:  postgresDatabaseCmd{},
 			wantErr: false,
 		},
+		{
+			name:   "update-backup-schedule",
+			create: storage.PostgresDatabaseParameters{BackupSchedule: storage.DatabaseBackupScheduleCalendarDisabled},
+			update: postgresDatabaseCmd{BackupSchedule: ptr.To(storage.DatabaseBackupScheduleCalendarDaily)},
+			want:   storage.PostgresDatabaseParameters{BackupSchedule: storage.DatabaseBackupScheduleCalendarDaily},
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {