Renamed methods to create 'NestingObserver'.

Author: nicolaiparlog

src/org/codefx/libfx/nesting/NestingObserver.java

@@ -22,8 +22,8 @@
  * present.
  * <p>
  * The observer is created with a {@link NestingObserverBuilder} which can be obtained from
- * {@link NestingObserver#observe(Nesting) observe}. After setting some of the methods mentioned above, the observer is
- * built by calling {@link NestingObserverBuilder#build()}.
+ * {@link NestingObserver#forNesting(Nesting) observe}. After setting some of the methods mentioned above, the observer
+ * is built by calling {@link NestingObserverBuilder#observe()}.
  *
  * @param <O>
  *            the type of the nesting hierarchy's innermost {@link Observable}
@@ -83,7 +83,7 @@ private NestingObserver(NestingObserverBuilder<O> builder) {
 	 *            the observed {@link Nesting}
 	 * @return a new {@link NestingObserverBuilder}
 	 */
-	public static <O extends Observable> NestingObserverBuilder<O> observe(Nesting<O> nesting) {
+	public static <O extends Observable> NestingObserverBuilder<O> forNesting(Nesting<O> nesting) {
 		return new NestingObserverBuilder<O>(nesting);
 	}
 
@@ -211,11 +211,10 @@ public NestingObserverBuilder<O> whenInnerObservableChanges(BiConsumer<Boolean,
 
 		/**
 		 * Builds a observer from this builder's settings.
-		 *
-		 * @return a new {@link NestingObserver}
 		 */
-		public NestingObserver<O> build() {
-			return new NestingObserver<O>(this);
+		@SuppressWarnings("unused")
+		public void observe() {
+			new NestingObserver<O>(this);
 		}
 
 	}

src/org/codefx/libfx/nesting/property/PropertyToNestingBinding.java

@@ -46,15 +46,15 @@ public static <T> void bind(
 		// the 'innerObservablePresentSetter' only accepts one Boolean; create a 'BiConsumer' from it,
 		// which accepts two and ignores the first
 		BiConsumer<Boolean, Boolean> innerObservablePresentBiSetter =
-				(oldPropertyPresent, newPropertyPresent) -> innerObservablePresentSetter.accept(newPropertyPresent);
+				(any, newPropertyPresent) -> innerObservablePresentSetter.accept(newPropertyPresent);
 
-				// use a nesting observer to accomplish the binding/unbinding
+		// use a nesting observer to accomplish the binding/unbinding
 		NestingObserver
-				.observe(nesting)
+				.forNesting(nesting)
 				.withOldInnerObservable(oldProperty -> nestedProperty.unbindBidirectional(oldProperty))
 				.withNewInnerObservable(newProperty -> nestedProperty.bindBidirectional(newProperty))
 				.whenInnerObservableChanges(innerObservablePresentBiSetter)
-				.build();
+				.observe();
 	}
 
 }

test/org/codefx/libfx/nesting/NestingObserverTest.java

@@ -62,11 +62,11 @@ public void setUpObservation(INNER_OBSERVABLE_INITIALLY_PRESENT initiallyPresent
 
 		// create a nesting observer for the nesting which calls the verifier's methods
 		NestingObserver
-				.observe(nesting)
+				.forNesting(nesting)
 				.withOldInnerObservable(verifier::oldInnerObservableMethod)
 				.withNewInnerObservable(verifier::newInnerObservableMethod)
 				.whenInnerObservableChanges(verifier::innerObservableChangesMethod)
-				.build();
+				.observe();
 
 		// creating the observer already called some methods; reset the mock to not confuse the counts
 		if (resetMock.toBoolean())