Fixed findoutlie/detectors.py and findoutlie/tests/test_detectors.py

Author: jagruti8

findoutlie/detectors.py

@@ -52,22 +52,13 @@ def iqr_detector(measures, iqr_proportion=1.5):
     # * You'll likely need np.logical_or
     # https://textbook.nipraxis.org/numpy_logical.html
     # +++your code here+++
-
+    # Calculate the quartiles of the data
     Q1 = np.percentile(measures, 25, interpolation="midpoint")
     Q2 = np.percentile(measures, 50, interpolation="midpoint")
     Q3 = np.percentile(measures, 75, interpolation="midpoint")
+    # Calculate the interquartile range
     IQR = Q3 - Q1
-
-    outlier = []
-
-    for i in range(len(measures)):
-        if (measures[i] > (Q3 + IQR * iqr_proportion)) | (
-            measures[i] < (Q1 - IQR * iqr_proportion)
-        ):
+    # Calculate the outliers
+    outliers = np.logical_or(measures > (Q3 + IQR * iqr_proportion), measures < (Q1 - IQR * iqr_proportion))
+    return outliers
 
-            outlier.append(True)
-        else:
-            outlier.append(False)
-
-    #print(outlier)
-    return np.array(outlier)

findoutlie/tests/test_detectors.py

@@ -19,15 +19,15 @@
 # Hint: sys.path
 # Hint: see the solutions if you are stuck.
 # +++your code here+++
+findoutlie_dir = MY_DIR.parent
+print("The directory containing detectors is {}".format(str(findoutlie_dir)))
+sys.path.append(str(findoutlie_dir))
 
-#import sys
-#export PYTHONPATH=$PYTHONPATH:C:/Users/nauma/Documents/nipraxis-work/diagnostics-NME/findoutlie
-#sys.path.append('C:/Users/nauma/Documents/nipraxis-work/diagnostics-NME/findoutlie')
 import numpy as np
 
 # This import needs the directory containing the findoutlie directory
 # on the Python path.
-from findoutlie.detectors import iqr_detector
+from detectors import iqr_detector
 
 
 def test_iqr_detector():