Clean up unreachable code

[oesteban]

Hi team,

I'm going through your project. A minor thing that would require some cleanup is at the end of the metrics.py file:

diagnostics-NME/solutions/metrics.py

Lines 41 to 44 in 6653c80

	# LAB(replace solution)
	# This is a placeholder, replace it to write your solution.
	raise NotImplementedError("Code up this function")
	# LAB(end solution)

Because of the return, that code will not be executed. Therefore, it is better to just remove it.

[oesteban]

Another one here:

diagnostics-NME/solutions/validate_data.py

Lines 30 to 35 in 6653c80

	# LAB(replace solution)
	# This is a placeholder, replace it to write your solution.
	raise NotImplementedError(
	"This is just a template -- you are expected to code this."
	)
	# LAB(end solution)

[oesteban]

One more here:

diagnostics-NME/solutions/validate_data.py

Lines 74 to 80 in 6653c80

	return
	# LAB(replace solution)
	# This is a placeholder, replace it to write your solution.
	raise NotImplementedError(
	"This is just a template -- fill out the template with code."
	)
	# LAB(end solution)

This one has also that ending return. If you clean up the code, the return becomes unnecessary as functions that do not have a return instruction will return None.

If you want to be very explicit (which is not a bad idea), then it's better to do:

    return None