Skip to content

Commit 1042c26

Browse files
josephmjeoesteban
authored andcommitted
remove duplicated code
1 parent 9781f60 commit 1042c26

File tree

4 files changed

+8
-453
lines changed

4 files changed

+8
-453
lines changed

MANIFEST.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,4 @@ include dmriprep/_version.py
88

99
# data
1010
include dmriprep/reports/dmriprep.yml
11-
include dmriprep/reports/report.tpl
11+
include dmriprep/reports/report.tpl

dmriprep/cli/run.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ def main():
337337
sentry_sdk.capture_message('dMRIPrep finished without errors',
338338
level='info')
339339
finally:
340-
from dmriprep.reports import generate_reports
340+
from niworkflows.reports import generate_reports
341341
from subprocess import check_call, CalledProcessError, TimeoutExpired
342342
from pkg_resources import resource_filename as pkgrf
343343
from shutil import copyfile
@@ -384,7 +384,9 @@ def main():
384384

385385
# Generate reports phase
386386
failed_reports = generate_reports(
387-
subject_list, output_dir, work_dir, run_uuid, packagename='dmriprep')
387+
subject_list, output_dir, work_dir, run_uuid,
388+
config=pkgrf('dmriprep', 'reports/dmriprep.yml'),
389+
packagename='dmriprep')
388390
write_derivative_description(bids_dir, output_dir / 'dmriprep')
389391

390392
if failed_reports and not opts.notrack:
@@ -410,7 +412,7 @@ def build_workflow(opts, retval):
410412

411413
from nipype import logging as nlogging, config as ncfg
412414
from niworkflows.utils.bids import collect_participants
413-
from dmriprep.reports import generate_reports
415+
from niworkflows.reports import generate_reports
414416
from ..__about__ import __version__
415417
from ..workflows.base import init_dmriprep_wf
416418

@@ -524,12 +526,14 @@ def build_workflow(opts, retval):
524526

525527
# Called with reports only
526528
if opts.reports_only:
529+
from pkg_resources import resource_filename as pkgrf
527530
build_log.log(25, 'Running --reports-only on participants %s', ', '.join(subject_list))
528531
if opts.run_uuid is not None:
529532
run_uuid = opts.run_uuid
530533
retval['run_uuid'] = run_uuid
531534
retval['return_code'] = generate_reports(
532535
subject_list, output_dir, work_dir, run_uuid,
536+
config=pkgrf('dmriprep', 'reports/dmriprep.yml'),
533537
packagename='dmriprep')
534538
return retval
535539

dmriprep/reports/__init__.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +0,0 @@
1-
# emacs: -*- mode: python; py-indent-offset: 4; indent-tabs-mode: nil -*-
2-
# vi: set ft=python sts=4 ts=4 sw=4 et:
3-
4-
from .core import generate_reports
5-
6-
__all__ = ['generate_reports']

0 commit comments

Comments
 (0)