Skip to content

Commit 3c836e8

Browse files
authored
FIX: Disable boldref-space outputs unless requested (#3159)
If `--level full`, boldref-space outputs are generated. This is due to a misplaced logical OR instead of AND. The intended effect of the line was to disable boldref-space outputs unless `level == 'full'`.
2 parents 87a90dd + 904038c commit 3c836e8

File tree

7 files changed

+1
-33
lines changed

7 files changed

+1
-33
lines changed

.circleci/ds005_fasttrack_outputs.txt

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,12 @@ sub-01/anat/sub-01_hemi-R_desc-reg_sphere.surf.gii
2323
sub-01/anat/sub-01_hemi-R_space-fsLR_desc-msmsulc_sphere.surf.gii
2424
sub-01/anat/sub-01_hemi-R_space-fsLR_desc-reg_sphere.surf.gii
2525
sub-01/func
26-
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-brain_mask.json
27-
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-brain_mask.nii.gz
2826
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-confounds_timeseries.json
2927
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-confounds_timeseries.tsv
3028
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-coreg_boldref.json
3129
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-coreg_boldref.nii.gz
3230
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-hmc_boldref.json
3331
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-hmc_boldref.nii.gz
34-
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-preproc_bold.json
35-
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-preproc_bold.nii.gz
3632
sub-01/func/sub-01_task-mixedgamblestask_run-01_from-boldref_to-T1w_mode-image_desc-coreg_xfm.json
3733
sub-01/func/sub-01_task-mixedgamblestask_run-01_from-boldref_to-T1w_mode-image_desc-coreg_xfm.txt
3834
sub-01/func/sub-01_task-mixedgamblestask_run-01_from-orig_to-boldref_mode-image_desc-hmc_xfm.json
@@ -45,16 +41,12 @@ sub-01/func/sub-01_task-mixedgamblestask_run-01_hemi-R_space-fsaverage5_bold.fun
4541
sub-01/func/sub-01_task-mixedgamblestask_run-01_hemi-R_space-fsaverage5_bold.json
4642
sub-01/func/sub-01_task-mixedgamblestask_run-01_hemi-R_space-fsnative_bold.func.gii
4743
sub-01/func/sub-01_task-mixedgamblestask_run-01_hemi-R_space-fsnative_bold.json
48-
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-brain_mask.json
49-
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-brain_mask.nii.gz
5044
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-confounds_timeseries.json
5145
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-confounds_timeseries.tsv
5246
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-coreg_boldref.json
5347
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-coreg_boldref.nii.gz
5448
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-hmc_boldref.json
5549
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-hmc_boldref.nii.gz
56-
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-preproc_bold.json
57-
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-preproc_bold.nii.gz
5850
sub-01/func/sub-01_task-mixedgamblestask_run-02_from-boldref_to-T1w_mode-image_desc-coreg_xfm.json
5951
sub-01/func/sub-01_task-mixedgamblestask_run-02_from-boldref_to-T1w_mode-image_desc-coreg_xfm.txt
6052
sub-01/func/sub-01_task-mixedgamblestask_run-02_from-orig_to-boldref_mode-image_desc-hmc_xfm.json

.circleci/ds005_outputs.txt

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,16 +43,12 @@ sub-01/anat/sub-01_label-CSF_probseg.nii.gz
4343
sub-01/anat/sub-01_label-GM_probseg.nii.gz
4444
sub-01/anat/sub-01_label-WM_probseg.nii.gz
4545
sub-01/func
46-
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-brain_mask.json
47-
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-brain_mask.nii.gz
4846
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-confounds_timeseries.json
4947
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-confounds_timeseries.tsv
5048
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-coreg_boldref.json
5149
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-coreg_boldref.nii.gz
5250
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-hmc_boldref.json
5351
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-hmc_boldref.nii.gz
54-
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-preproc_bold.json
55-
sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-preproc_bold.nii.gz
5652
sub-01/func/sub-01_task-mixedgamblestask_run-01_from-boldref_to-T1w_mode-image_desc-coreg_xfm.json
5753
sub-01/func/sub-01_task-mixedgamblestask_run-01_from-boldref_to-T1w_mode-image_desc-coreg_xfm.txt
5854
sub-01/func/sub-01_task-mixedgamblestask_run-01_from-orig_to-boldref_mode-image_desc-hmc_xfm.json
@@ -65,16 +61,12 @@ sub-01/func/sub-01_task-mixedgamblestask_run-01_hemi-R_space-fsaverage5_bold.fun
6561
sub-01/func/sub-01_task-mixedgamblestask_run-01_hemi-R_space-fsaverage5_bold.json
6662
sub-01/func/sub-01_task-mixedgamblestask_run-01_hemi-R_space-fsnative_bold.func.gii
6763
sub-01/func/sub-01_task-mixedgamblestask_run-01_hemi-R_space-fsnative_bold.json
68-
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-brain_mask.json
69-
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-brain_mask.nii.gz
7064
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-confounds_timeseries.json
7165
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-confounds_timeseries.tsv
7266
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-coreg_boldref.json
7367
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-coreg_boldref.nii.gz
7468
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-hmc_boldref.json
7569
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-hmc_boldref.nii.gz
76-
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-preproc_bold.json
77-
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-preproc_bold.nii.gz
7870
sub-01/func/sub-01_task-mixedgamblestask_run-02_from-boldref_to-T1w_mode-image_desc-coreg_xfm.json
7971
sub-01/func/sub-01_task-mixedgamblestask_run-02_from-boldref_to-T1w_mode-image_desc-coreg_xfm.txt
8072
sub-01/func/sub-01_task-mixedgamblestask_run-02_from-orig_to-boldref_mode-image_desc-hmc_xfm.json

.circleci/ds005_partial_fasttrack_outputs.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,16 +51,12 @@ sub-01/fmap/sub-01_run-02_fmapid-auto00000_desc-magnitude_fieldmap.nii.gz
5151
sub-01/fmap/sub-01_run-02_fmapid-auto00000_desc-preproc_fieldmap.json
5252
sub-01/fmap/sub-01_run-02_fmapid-auto00000_desc-preproc_fieldmap.nii.gz
5353
sub-01/func
54-
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-brain_mask.json
55-
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-brain_mask.nii.gz
5654
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-confounds_timeseries.json
5755
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-confounds_timeseries.tsv
5856
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-coreg_boldref.json
5957
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-coreg_boldref.nii.gz
6058
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-hmc_boldref.json
6159
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-hmc_boldref.nii.gz
62-
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-preproc_bold.json
63-
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-preproc_bold.nii.gz
6460
sub-01/func/sub-01_task-mixedgamblestask_run-02_from-boldref_to-T1w_mode-image_desc-coreg_xfm.json
6561
sub-01/func/sub-01_task-mixedgamblestask_run-02_from-boldref_to-T1w_mode-image_desc-coreg_xfm.txt
6662
sub-01/func/sub-01_task-mixedgamblestask_run-02_from-boldref_to-auto00000_mode-image_xfm.json

.circleci/ds005_partial_outputs.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,16 +73,12 @@ sub-01/fmap/sub-01_run-02_fmapid-auto00000_desc-magnitude_fieldmap.nii.gz
7373
sub-01/fmap/sub-01_run-02_fmapid-auto00000_desc-preproc_fieldmap.json
7474
sub-01/fmap/sub-01_run-02_fmapid-auto00000_desc-preproc_fieldmap.nii.gz
7575
sub-01/func
76-
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-brain_mask.json
77-
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-brain_mask.nii.gz
7876
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-confounds_timeseries.json
7977
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-confounds_timeseries.tsv
8078
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-coreg_boldref.json
8179
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-coreg_boldref.nii.gz
8280
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-hmc_boldref.json
8381
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-hmc_boldref.nii.gz
84-
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-preproc_bold.json
85-
sub-01/func/sub-01_task-mixedgamblestask_run-02_desc-preproc_bold.nii.gz
8682
sub-01/func/sub-01_task-mixedgamblestask_run-02_from-boldref_to-auto00000_mode-image_xfm.json
8783
sub-01/func/sub-01_task-mixedgamblestask_run-02_from-boldref_to-auto00000_mode-image_xfm.txt
8884
sub-01/func/sub-01_task-mixedgamblestask_run-02_from-boldref_to-T1w_mode-image_desc-coreg_xfm.json

.circleci/ds210_fasttrack_outputs.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ sub-02/func/sub-02_task-cuedSGT_run-01_desc-coreg_boldref.json
3131
sub-02/func/sub-02_task-cuedSGT_run-01_desc-coreg_boldref.nii.gz
3232
sub-02/func/sub-02_task-cuedSGT_run-01_desc-hmc_boldref.json
3333
sub-02/func/sub-02_task-cuedSGT_run-01_desc-hmc_boldref.nii.gz
34-
sub-02/func/sub-02_task-cuedSGT_run-01_desc-preproc_bold.json
35-
sub-02/func/sub-02_task-cuedSGT_run-01_desc-preproc_bold.nii.gz
3634
sub-02/func/sub-02_task-cuedSGT_run-01_echo-1_desc-preproc_bold.json
3735
sub-02/func/sub-02_task-cuedSGT_run-01_echo-1_desc-preproc_bold.nii.gz
3836
sub-02/func/sub-02_task-cuedSGT_run-01_echo-2_desc-preproc_bold.json
@@ -45,8 +43,6 @@ sub-02/func/sub-02_task-cuedSGT_run-01_from-boldref_to-T1w_mode-image_desc-coreg
4543
sub-02/func/sub-02_task-cuedSGT_run-01_from-boldref_to-T1w_mode-image_desc-coreg_xfm.txt
4644
sub-02/func/sub-02_task-cuedSGT_run-01_from-orig_to-boldref_mode-image_desc-hmc_xfm.json
4745
sub-02/func/sub-02_task-cuedSGT_run-01_from-orig_to-boldref_mode-image_desc-hmc_xfm.txt
48-
sub-02/func/sub-02_task-cuedSGT_run-01_space-boldref_T2starmap.json
49-
sub-02/func/sub-02_task-cuedSGT_run-01_space-boldref_T2starmap.nii.gz
5046
sub-02/func/sub-02_task-cuedSGT_run-01_space-MNI152NLin2009cAsym_boldref.nii.gz
5147
sub-02/func/sub-02_task-cuedSGT_run-01_space-MNI152NLin2009cAsym_desc-brain_mask.nii.gz
5248
sub-02/func/sub-02_task-cuedSGT_run-01_space-MNI152NLin2009cAsym_desc-preproc_bold.json

.circleci/ds210_outputs.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@ sub-02/func/sub-02_task-cuedSGT_run-01_desc-coreg_boldref.json
4141
sub-02/func/sub-02_task-cuedSGT_run-01_desc-coreg_boldref.nii.gz
4242
sub-02/func/sub-02_task-cuedSGT_run-01_desc-hmc_boldref.json
4343
sub-02/func/sub-02_task-cuedSGT_run-01_desc-hmc_boldref.nii.gz
44-
sub-02/func/sub-02_task-cuedSGT_run-01_desc-preproc_bold.json
45-
sub-02/func/sub-02_task-cuedSGT_run-01_desc-preproc_bold.nii.gz
4644
sub-02/func/sub-02_task-cuedSGT_run-01_echo-1_desc-preproc_bold.json
4745
sub-02/func/sub-02_task-cuedSGT_run-01_echo-1_desc-preproc_bold.nii.gz
4846
sub-02/func/sub-02_task-cuedSGT_run-01_echo-2_desc-preproc_bold.json
@@ -55,8 +53,6 @@ sub-02/func/sub-02_task-cuedSGT_run-01_from-boldref_to-T1w_mode-image_desc-coreg
5553
sub-02/func/sub-02_task-cuedSGT_run-01_from-boldref_to-T1w_mode-image_desc-coreg_xfm.txt
5654
sub-02/func/sub-02_task-cuedSGT_run-01_from-orig_to-boldref_mode-image_desc-hmc_xfm.json
5755
sub-02/func/sub-02_task-cuedSGT_run-01_from-orig_to-boldref_mode-image_desc-hmc_xfm.txt
58-
sub-02/func/sub-02_task-cuedSGT_run-01_space-boldref_T2starmap.json
59-
sub-02/func/sub-02_task-cuedSGT_run-01_space-boldref_T2starmap.nii.gz
6056
sub-02/func/sub-02_task-cuedSGT_run-01_space-MNI152NLin2009cAsym_boldref.nii.gz
6157
sub-02/func/sub-02_task-cuedSGT_run-01_space-MNI152NLin2009cAsym_desc-brain_mask.nii.gz
6258
sub-02/func/sub-02_task-cuedSGT_run-01_space-MNI152NLin2009cAsym_desc-preproc_bold.json

fmriprep/workflows/bold/base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ def init_bold_wf(
335335
]) # fmt:skip
336336

337337
boldref_out = bool(nonstd_spaces.intersection(('func', 'run', 'bold', 'boldref', 'sbref')))
338-
boldref_out |= config.workflow.level == 'full'
338+
boldref_out &= config.workflow.level == 'full'
339339
echos_out = multiecho and config.execution.me_output_echos
340340

341341
if boldref_out or echos_out:

0 commit comments

Comments
 (0)