Skip to content

Commit 4afb89b

Browse files
committed
[skip ci] Merge remote-tracking branch 'upstream/master' into ref/multiple-output-spaces
2 parents b4832dd + 517d50b commit 4afb89b

File tree

8 files changed

+41
-44
lines changed

8 files changed

+41
-44
lines changed

.circleci/config.yml

Lines changed: 20 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -294,47 +294,36 @@ jobs:
294294

295295

296296
build_docs:
297-
machine:
298-
image: circleci/classic:201711-01
299-
working_directory: /home/circleci/out/docs
297+
docker:
298+
- image: python:latest
299+
working_directory: /tmp/src/fmriprep
300300
steps:
301-
- checkout:
302-
path: /home/circleci/src/fmriprep
301+
- checkout
303302
- run:
304303
name: Check whether build should be skipped
305304
command: |
306-
cd /home/circleci/src/fmriprep
307305
if [[ "$( git log --format=oneline -n 1 $CIRCLE_SHA1 | grep -i -E '\[skip[ _]?docs\]' )" != "" ]]; then
308306
echo "Skipping doc building job"
309307
circleci step halt
310308
fi
311-
312-
- attach_workspace:
313-
at: /tmp
314309
- run:
315-
name: Load Docker image layer cache
316-
no_output_timeout: 30m
310+
name: Check Python version and upgrade pip
317311
command: |
318-
docker info
319-
set +o pipefail
320-
if [ -f /tmp/cache/docker.tar.gz ]; then
321-
sudo apt update && sudo apt -y install pigz
322-
pigz -d --stdout /tmp/cache/docker.tar.gz | docker load
323-
docker images
324-
fi
312+
python --version
313+
python -m pip install -U pip
325314
- run:
326-
name: Build fMRIPrep documentation
327-
no_output_timeout: 2h
315+
name: Install graphviz
328316
command: |
329-
docker run -ti --rm=false -v $PWD:/_build_html \
330-
--entrypoint=sphinx-build poldracklab/fmriprep:latest \
331-
-T -E -b html -d _build/doctrees-readthedocs -W -D \
332-
language=en /src/fmriprep/docs/ /_build_html 2>&1 \
333-
| tee $PWD/builddocs.log
334-
cat $PWD/builddocs.log
335-
grep -qv "ERROR" $PWD/builddocs.log
317+
apt-get update
318+
apt-get install -y graphviz
319+
- run:
320+
name: Install fMRIPrep
321+
command: python -m pip install ".[doc]"
322+
- run:
323+
name: Build documentation
324+
command: make SPHINXOPTS="-W" -C docs html
336325
- store_artifacts:
337-
path: /home/circleci/out/docs
326+
path: /tmp/src/fmriprep/docs/_build/html
338327

339328
ds005:
340329
machine:
@@ -802,6 +791,9 @@ workflows:
802791
jobs:
803792
- build:
804793
filters:
794+
branches:
795+
ignore:
796+
- /docs?\/.*/
805797
tags:
806798
only: /.*/
807799

@@ -828,8 +820,6 @@ workflows:
828820
only: /.*/
829821

830822
- build_docs:
831-
requires:
832-
- build
833823
filters:
834824
branches:
835825
ignore:

docs/environment.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ dependencies:
2828
- svgutils
2929
- nitime
3030
- nilearn!=0.5.0,!=0.5.1
31-
- niworkflows<0.10.0a0,>=0.9.0
32-
- smriprep<0.3.0a0,>=0.2.0
31+
- git+https://github.com/poldracklab/niworkflows.git@e8f677a0407fc312b7f3d87a4c47726ceb8cd975#egg=niworkflows
3332
- tedana>=0.0.5
33+
- smriprep<0.3.0a0,>=0.2.0
34+
- templateflow<0.2.0a0,>=0.1.3

docs/workflows.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ is presented below:
2020

2121
from fmriprep.workflows.base import init_single_subject_wf
2222
from collections import namedtuple, OrderedDict
23-
BIDSLayout = namedtuple('BIDSLayout', ['root'], defaults='.')
23+
BIDSLayout = namedtuple('BIDSLayout', ['root'])
2424
wf = init_single_subject_wf(
2525
anat_only=False,
2626
aroma_melodic_dim=-200,
@@ -35,7 +35,7 @@ is presented below:
3535
freesurfer=True,
3636
hires=True,
3737
ignore=[],
38-
layout=BIDSLayout(),
38+
layout=BIDSLayout('.'),
3939
longitudinal=False,
4040
low_mem=False,
4141
medial_surface_nan=False,
@@ -276,7 +276,7 @@ BOLD preprocessing
276276

277277
from collections import namedtuple, OrderedDict
278278
from fmriprep.workflows.bold.base import init_func_preproc_wf
279-
BIDSLayout = namedtuple('BIDSLayout', ['root'], defaults='.')
279+
BIDSLayout = namedtuple('BIDSLayout', ['root'])
280280
wf = init_func_preproc_wf(
281281
aroma_melodic_dim=-200,
282282
bold2t1w_dof=9,
@@ -301,7 +301,7 @@ BOLD preprocessing
301301
use_aroma=False,
302302
use_bbr=True,
303303
use_syn=True,
304-
layout=BIDSLayout(),
304+
layout=BIDSLayout('.'),
305305
num_bold=1,
306306
)
307307

fmriprep/__about__.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,8 @@
8888
'nilearn!=0.5.0,!=0.5.1',
8989
'nipype>=1.1.6',
9090
'nitime',
91-
'niworkflows<0.10.0a0,>=0.9.0',
91+
'niworkflows @ git+https://github.com/poldracklab/niworkflows.git@'
92+
'e8f677a0407fc312b7f3d87a4c47726ceb8cd975',
9293
'numpy',
9394
'pandas',
9495
'psutil>=5.4',
@@ -103,6 +104,8 @@
103104

104105

105106
LINKS_REQUIRES = [
107+
'git+https://github.com/poldracklab/niworkflows.git@'
108+
'e8f677a0407fc312b7f3d87a4c47726ceb8cd975#egg=niworkflows',
106109
]
107110

108111
TESTS_REQUIRES = [

fmriprep/workflows/base.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ def init_fmriprep_wf(
7979
8080
import os
8181
from collections import namedtuple, OrderedDict
82-
BIDSLayout = namedtuple('BIDSLayout', ['root'], defaults='.')
82+
BIDSLayout = namedtuple('BIDSLayout', ['root'])
8383
from fmriprep.workflows.base import init_fmriprep_wf
8484
os.environ['FREESURFER_HOME'] = os.getcwd()
8585
wf = init_fmriprep_wf(
@@ -96,7 +96,7 @@ def init_fmriprep_wf(
9696
freesurfer=True,
9797
hires=True,
9898
ignore=[],
99-
layout=BIDSLayout(),
99+
layout=BIDSLayout('.'),
100100
longitudinal=False,
101101
low_mem=False,
102102
medial_surface_nan=False,
@@ -300,7 +300,7 @@ def init_single_subject_wf(
300300
301301
from fmriprep.workflows.base import init_single_subject_wf
302302
from collections import namedtuple, OrderedDict
303-
BIDSLayout = namedtuple('BIDSLayout', ['root'], defaults='.')
303+
BIDSLayout = namedtuple('BIDSLayout', ['root'])
304304
wf = init_single_subject_wf(
305305
anat_only=False,
306306
aroma_melodic_dim=-200,
@@ -315,7 +315,7 @@ def init_single_subject_wf(
315315
freesurfer=True,
316316
hires=True,
317317
ignore=[],
318-
layout=BIDSLayout(),
318+
layout=BIDSLayout('.'),
319319
longitudinal=False,
320320
low_mem=False,
321321
medial_surface_nan=False,
@@ -336,6 +336,7 @@ def init_single_subject_wf(
336336
use_syn=True,
337337
)
338338
339+
339340
Parameters
340341
341342
anat_only : bool

fmriprep/workflows/bold/base.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ def init_func_preproc_wf(
8686
8787
from fmriprep.workflows.bold import init_func_preproc_wf
8888
from collections import namedtuple, OrderedDict
89-
BIDSLayout = namedtuple('BIDSLayout', ['root'], defaults='.')
89+
BIDSLayout = namedtuple('BIDSLayout', ['root'])
9090
wf = init_func_preproc_wf(
9191
aroma_melodic_dim=-200,
9292
bold2t1w_dof=9,
@@ -111,7 +111,7 @@ def init_func_preproc_wf(
111111
use_aroma=False,
112112
use_bbr=True,
113113
use_syn=True,
114-
layout=BIDSLayout(),
114+
layout=BIDSLayout('.'),
115115
num_bold=1,
116116
)
117117

pyproject.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
[build-system]
2+
requires = ["pip>=18.1", "setuptools>=40.8", "wheel", "numpy"]

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
nilearn!=0.5.0,!=0.5.1
2-
niworkflows<0.10.0a0,>=0.9.0
2+
git+https://github.com/poldracklab/niworkflows.git@e8f677a0407fc312b7f3d87a4c47726ceb8cd975#egg=niworkflows
33
smriprep<0.3.0a0,>=0.2.0
44
templateflow<0.2.0a0,>=0.1.3

0 commit comments

Comments
 (0)