Skip to content

Commit 58b8865

Browse files
effigiesoesteban
andauthored
[skip ci] Apply suggestions from code review
Co-Authored-By: oesteban <[email protected]>
1 parent f9a53a8 commit 58b8865

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

docs/usage.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ Therefore, in upcoming versions of fMRIPrep, it will be possible to run it with
8686
``--output-spaces MNIPediatricAsym:res-2:cohort-2`` where ``cohort-2`` would select
8787
the template instance for the, say, 24-48 months old range.
8888

89-
When specifying surface spaces (e.g. ``fsaverage``), the legacy identifiers from
89+
When specifying surface spaces (e.g., ``fsaverage``), the legacy identifiers from
9090
FreeSurfer will be supported (e.g. ``fsaverage5``) although the use of the density
9191
modifier would be preferred (i.e. ``fsaverage:den-10k`` for ``fsaverage5``).
9292

@@ -132,7 +132,7 @@ Preprocessing blocks depending on standard templates
132132

133133
Some modules of the pipeline (e.g. the ICA-AROMA denoising, the generation of
134134
HCP compatible *grayordinates* files, or the *fieldmap-less* distortion correction)
135-
perform on specific template spaces.
135+
operate in specific template spaces.
136136
When selecting those modules to be included (using any of the following flags:
137137
``--use-aroma``, ``--cifti-outputs``, ``--use-syn-sdc``) will modify the list of
138138
output spaces to include the space identifiers they require, should the

docs/workflows.rst

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,9 @@ This file should be placed in the ``sub-*/anat`` directory of the BIDS dataset
146146
to be run through *fMRIPrep*.
147147
Because lesion masks are not currently part of the BIDS specification, it is also necessary to
148148
include a ``.bidsignore`` file in the root of your dataset directory. This will prevent
149-
`bids-validator <https://github.com/bids-standard/bids-validator#bidsignore>`_ from complaining that your dataset not BIDS valid, which prevents
150-
*fMRIPrep* from running. Your ``.bidsignore`` file should include the following line::
149+
`bids-validator <https://github.com/bids-standard/bids-validator#bidsignore>`_ from complaining
150+
that your dataset is not valid BIDS, which prevents *fMRIPrep* from running.
151+
Your ``.bidsignore`` file should include the following line::
151152

152153
*lesion_roi.nii.gz
153154
@@ -577,7 +578,7 @@ regressors (a separate GLM with both noise and signal regressors needs to be use
577578
Therefore instead of regressors, *fMRIPrep* produces *non*-aggressive denoised 4D NIFTI
578579
files in the MNI space:
579580

580-
``*bold_space-MNI152NLin6Asym-smoothAROMAnonaggr_brainmask.nii.gz``
581+
``*bold_space-MNI152NLin6Asym_desc-smoothAROMAnonaggr_brainmask.nii.gz``
581582

582583
Additionally, the MELODIC mix and noise component indices will
583584
be generated, so non-aggressive denoising can be manually performed in the T1w space with ``fsl_regfilt``, *e.g.*::

fmriprep/workflows/bold/base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,7 @@ def init_func_preproc_wf(
401401
name='summary', mem_gb=DEFAULT_MEMORY_MIN_GB, run_without_submitting=True)
402402

403403
# CIfTI output: currently, we only support fsaverage{5,6}
404-
cifti_spaces = set([s for s in output_spaces.keys() if s in ('fsaverage5', 'fsaverage6')])
404+
cifti_spaces = set(s for s in output_spaces.keys() if s in ('fsaverage5', 'fsaverage6'))
405405
fsaverage_den = output_spaces.get('fsaverage', {}).get('den')
406406
if fsaverage_den:
407407
cifti_spaces.add(FSAVERAGE_DENSITY[fsaverage_den])

0 commit comments

Comments
 (0)