STY: ruff --fix --unsafe-fixes (with cleanup) [git-blame-ignore-rev]

Author: effigies

.maint/paper_author_list.py

@@ -55,7 +55,7 @@ def _aslist(inlist):
         '%s.'
         % '; '.join(
             [
-                '%s \\ :sup:`%s`\\ ' % (i['name'], idx)
+                '{} \\ :sup:`{}`\\ '.format(i['name'], idx)
                 for i, idx in zip(author_matches, aff_indexes, strict=False)
             ]
         )

.maint/update_authors.py

@@ -119,10 +119,11 @@ def get_git_lines(fname='line-contributors.txt'):
     if not lines:
         raise RuntimeError(
             """\
-Could not find line-contributors from git repository.%s"""
-            % """ \
+Could not find line-contributors from git repository.{}""".format(
+                """ \
 git-line-summary not found, please install git-extras. """
-            * (git_line_summary_path is None)
+                * (git_line_summary_path is None)
+            )
         )
     return [' '.join(line.strip().split()[1:-1]) for line in lines if '%' in line]
 
@@ -242,7 +243,7 @@ def publication(
     hits = [hit for hit in hits if hit['name'] not in pi_names] + pi_hits
 
     def _aslist(value):
-        if isinstance(value, (list, tuple)):
+        if isinstance(value, list | tuple):
             return value
         return [value]
 
@@ -273,7 +274,12 @@ def _aslist(value):
     print('Authors (%d):' % len(hits))
     print(
         '%s.'
-        % '; '.join(['%s \\ :sup:`%s`\\ ' % (i['name'], idx) for i, idx in zip(hits, aff_indexes, strict=False)])
+        % '; '.join(
+            [
+                '{} \\ :sup:`{}`\\ '.format(i['name'], idx)
+                for i, idx in zip(hits, aff_indexes, strict=False)
+            ]
+        )
     )
 
     print(

.maint/update_zenodo.py

@@ -80,10 +80,11 @@ def get_git_lines(fname='line-contributors.txt'):
     if not lines:
         raise RuntimeError(
             """\
-Could not find line-contributors from git repository.%s"""
-            % """ \
+Could not find line-contributors from git repository.{}""".format(
+                """ \
 git-(line-)summary not found, please install git-extras. """
-            * (cmd[0] is None)
+                * (cmd[0] is None)
+            )
         )
     return [' '.join(line.strip().split()[1:-1]) for line in lines if '%' in line]
 

fmriprep/cli/parser.py

@@ -719,24 +719,22 @@ def _slice_time_ref(value, parser):
     latest = check_latest()
     if latest is not None and currentv < latest:
         print(
-            """\
-You are using fMRIPrep-%s, and a newer version of fMRIPrep is available: %s.
+            f"""\
+You are using fMRIPrep-{currentv}, and a newer version of fMRIPrep is available: {latest}.
 Please check out our documentation about how and when to upgrade:
-https://fmriprep.readthedocs.io/en/latest/faq.html#upgrading"""
-            % (currentv, latest),
+https://fmriprep.readthedocs.io/en/latest/faq.html#upgrading""",
             file=sys.stderr,
         )
 
     _blist = is_flagged()
     if _blist[0]:
         _reason = _blist[1] or 'unknown'
         print(
-            """\
-WARNING: Version %s of fMRIPrep (current) has been FLAGGED
-(reason: %s).
+            f"""\
+WARNING: Version {config.environment.version} of fMRIPrep (current) has been FLAGGED
+(reason: {_reason}).
 That means some severe flaw was found in it and we strongly
-discourage its usage."""
-            % (config.environment.version, _reason),
+discourage its usage.""",
             file=sys.stderr,
         )
 

fmriprep/cli/tests/test_parser.py

@@ -36,7 +36,7 @@
 
 
 @pytest.mark.parametrize(
-    'args,code',
+    ('args', 'code'),
     [
         ([], 2),
         (MIN_ARGS, 2),  # bids_dir does not exist
@@ -70,7 +70,7 @@ def test_parser_valid(tmp_path, args):
 
 
 @pytest.mark.parametrize(
-    'argval,gb',
+    ('argval', 'gb'),
     [
         ('1G', 1),
         ('1GB', 1),
@@ -99,7 +99,7 @@ def test_memory_arg(tmp_path, argval, gb):
     assert opts.memory_gb == gb
 
 
-@pytest.mark.parametrize('current,latest', [('1.0.0', '1.3.2'), ('1.3.2', '1.3.2')])
+@pytest.mark.parametrize(('current', 'latest'), [('1.0.0', '1.3.2'), ('1.3.2', '1.3.2')])
 def test_get_parser_update(monkeypatch, capsys, current, latest):
     """Make sure the out-of-date banner is shown."""
     expectation = Version(current) < Version(latest)
@@ -199,7 +199,7 @@ def test_slice_time_ref(tmp_path, st_ref):
 
 
 @pytest.mark.parametrize(
-    'args, expectation',
+    ('args', 'expectation'),
     (
         ([], False),
         (['--use-syn-sdc'], 'error'),

fmriprep/cli/version.py

@@ -87,7 +87,7 @@ def check_latest():
 def is_flagged():
     """Check whether current version is flagged."""
     # https://raw.githubusercontent.com/nipreps/fmriprep/master/.versions.json
-    flagged = tuple()
+    flagged = ()
     try:
         response = requests.get(
             url="""\

fmriprep/config.py

@@ -209,7 +209,7 @@
 class _Config:
     """An abstract class forbidding instantiation."""
 
-    _paths = tuple()
+    _paths = ()
 
     def __init__(self):
         """Avert instantiation."""
@@ -223,7 +223,7 @@ def load(cls, settings, init=True, ignore=None):
             if k in ignore or v is None:
                 continue
             if k in cls._paths:
-                if isinstance(v, (list, tuple)):
+                if isinstance(v, list | tuple):
                     setattr(cls, k, [Path(val).absolute() for val in v])
                 else:
                     setattr(cls, k, Path(v).absolute())
@@ -248,7 +248,7 @@ def get(cls):
             if callable(getattr(cls, k)):
                 continue
             if k in cls._paths:
-                if isinstance(v, (list, tuple)):
+                if isinstance(v, list | tuple):
                     v = [str(val) for val in v]
                 else:
                     v = str(v)

fmriprep/data/__init__.py

@@ -19,7 +19,6 @@
 from functools import cached_property
 from pathlib import Path
 from types import ModuleType
-from typing import Union
 
 try:
     from functools import cache
@@ -111,7 +110,7 @@ class Loader:
     .. automethod:: cached
     """
 
-    def __init__(self, anchor: Union[str, ModuleType]):
+    def __init__(self, anchor: str | ModuleType):
         self._anchor = anchor
         self.files = files(anchor)
         self.exit_stack = ExitStack()

fmriprep/interfaces/confounds.py

@@ -415,7 +415,7 @@ def _run_interface(self, runtime):
         names = {}
 
         for conf_el in self.inputs.confounds_list:
-            if isinstance(conf_el, (list, tuple)):
+            if isinstance(conf_el, list | tuple):
                 headers.append(conf_el[0])
                 if conf_el[1] is not None:
                     units[conf_el[0]] = conf_el[1]

fmriprep/interfaces/tests/test_reports.py

@@ -26,7 +26,7 @@
 
 
 @pytest.mark.parametrize(
-    'orientation,pe_dir,expected',
+    ('orientation', 'pe_dir', 'expected'),
     [
         ('RAS', 'j', 'Posterior-Anterior'),
         ('RAS', 'j-', 'Anterior-Posterior'),