Skip to content

Commit 9773f7e

Browse files
authored
Merge pull request #1716 from oesteban/maint/migrate-masks-tests
MAINT: Move regression tests of EPI masks over to Niworkflows
2 parents bf8a823 + 042fa26 commit 9773f7e

File tree

5 files changed

+4
-204
lines changed

5 files changed

+4
-204
lines changed

.circleci/config.yml

Lines changed: 3 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -176,42 +176,6 @@ jobs:
176176
- /tmp/data
177177
- /tmp/ds005/derivatives/freesurfer
178178

179-
get_regression_data:
180-
machine:
181-
# Ubuntu 14.04 with Docker 17.10.0-ce
182-
image: circleci/classic:201711-01
183-
working_directory: /home/circleci/data
184-
steps:
185-
- restore_cache:
186-
keys:
187-
- regression-v3-{{ .Revision }}
188-
- regression-v3-
189-
- run:
190-
name: Get truncated BOLD series
191-
command: |
192-
mkdir -p /tmp/data
193-
if [[ ! -d /tmp/data/fmriprep_bold_truncated ]]; then
194-
wget --retry-connrefused --waitretry=5 --read-timeout=20 --timeout=15 -t 0 -q \
195-
-O fmriprep_bold_truncated.tar.gz "https://osf.io/286yr/download"
196-
tar xvzf fmriprep_bold_truncated.tar.gz -C /tmp/data/
197-
else
198-
echo "Truncated BOLD series were cached"
199-
fi
200-
- run:
201-
name: Get pre-computed masks
202-
command: |
203-
if [[ ! -d /tmp/data/fmriprep_bold_mask ]]; then
204-
wget --retry-connrefused --waitretry=5 --read-timeout=20 --timeout=15 -t 0 -q \
205-
-O fmriprep_bold_mask.tar.gz "https://osf.io/s4f7b/download"
206-
tar xvzf fmriprep_bold_mask.tar.gz -C /tmp/data/
207-
else
208-
echo "Pre-computed masks were cached"
209-
fi
210-
- save_cache:
211-
key: regression-v3-{{ .Revision }}-{{ epoch }}
212-
paths:
213-
- /tmp/data
214-
215179
test_pytest:
216180
machine:
217181
image: circleci/classic:201711-01
@@ -237,9 +201,6 @@ jobs:
237201
- restore_cache:
238202
keys:
239203
- docker-v3-{{ .Branch }}-{{ .Revision }}
240-
- restore_cache:
241-
keys:
242-
- regression-v3-{{ .Revision }}
243204
- run:
244205
name: Load Docker image layer cache
245206
no_output_timeout: 30m
@@ -255,21 +216,10 @@ jobs:
255216
name: Run fMRIPrep tests
256217
no_output_timeout: 2h
257218
command: |
258-
mkdir /tmp/data/reports && \
259219
docker run -ti --rm=false \
260-
-v /tmp/data:/tmp/data \
261-
-e FMRIPREP_REGRESSION_SOURCE=/tmp/data/fmriprep_bold_truncated \
262-
-e FMRIPREP_REGRESSION_TARGETS=/tmp/data/fmriprep_bold_mask \
263-
-e FMRIPREP_REGRESSION_REPORTS=/tmp/data/reports \
264-
--entrypoint="py.test" poldracklab/fmriprep:latest \
265-
/src/fmriprep/ \
266-
-svx --doctest-modules --ignore=/src/fmriprep/docs --ignore=setup.py
267-
- run:
268-
name: Package new masks
269-
no_output_timeout: 10m
270-
working_directory: /tmp/data/reports
271-
command: |
272-
tar cfz fmriprep_bold_mask.tar.gz fmriprep_bold_mask/*/*.nii.gz
220+
--entrypoint="pytest" poldracklab/fmriprep:latest \
221+
/src/fmriprep/fmriprep -svx --doctest-modules
222+
273223
- run:
274224
name: Test fmriprep-wrapper (Python 2)
275225
command: |
@@ -953,18 +903,6 @@ workflows:
953903
tags:
954904
only: /.*/
955905

956-
- get_regression_data:
957-
filters:
958-
branches:
959-
ignore:
960-
- /docs?\/.*/
961-
- /ds005\/.*/
962-
- /ds054\/.*/
963-
- /ds210\/.*/
964-
- /docker\/.*/
965-
tags:
966-
only: /.*/
967-
968906
- build_docs:
969907
filters:
970908
branches:
@@ -989,7 +927,6 @@ workflows:
989927
- test_pytest:
990928
requires:
991929
- build
992-
- get_regression_data
993930
filters:
994931
branches:
995932
ignore:

fmriprep/data/epi_atlasbased_brainmask.json

Lines changed: 0 additions & 20 deletions
This file was deleted.

fmriprep/data/epi_registration_settings.json

Lines changed: 0 additions & 21 deletions
This file was deleted.

fmriprep/workflows/bold/tests/test_util.py

Lines changed: 0 additions & 96 deletions
This file was deleted.

setup.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ classifiers =
2020
[options]
2121
python_requires = >=3.5
2222
install_requires =
23-
niworkflows ~= 0.10.1
23+
niworkflows ~= 0.10.2
2424
smriprep ~= 0.3.1
2525
templateflow ~= 0.4.1
2626
nibabel >=2.2.1

0 commit comments

Comments
 (0)