Commit a1c53ad
authored
feat: Ignore non-steady-state volumes in T2*/S0 estimation (#3556)
Closes #3507. As of 25.1.0, tedana has an `--exclude` parameter in its
t2smap CLI, which allows users to ignore certain volumes when estimating
T2* and S0. This PR bumps the tedana version and leverages that
parameter to ignore dummy scans. If it proves useful, we could also
ignore high-motion volumes in the future.
## Changes proposed in this pull request
- Increase minimum tedana version from 25.0.0 to 25.1.0.
- Use estimated number of dummy scans to set `exclude` parameter in
t2smap call, so that those volumes do not contribute to the estimation
of T2*, which is in turn used to optimally combine the data across
echoes. I doubt the dummy scans actually have much effect on T2*
estimation, but it still stands to reason that they are not _helping_.
## Documentation that should be reviewed
<!--
Please summarize here the main changes to the documentation that the
reviewers should be aware of.
-->
<!--
Welcome, new contributors!
We ask you to read through the Contributing Guide:
https://github.com/nipreps/fmriprep/blob/master/CONTRIBUTING.md
These are guidelines intended to make communication easier by describing
a consistent process, but
don't worry if you don't get it everything exactly "right" on the first
try.
To boil it down, here are some highlights:
1) Consider starting a conversation in the issues list before submitting
a pull request. The discussion might save you a
lot of time coding.
2) Please use descriptive prefixes in your pull request title, such as
"ENH:" for an enhancement or "FIX:" for a bug fix.
(See the Contributing guide for the full set.) And consider adding a
"WIP" tag for works-in-progress.
3) Any code you submit will be licensed under the same terms (Apache
License 2.0) as the rest of fMRIPrep.
4) We invite every contributor to add themselves to the `.zenodo.json`
file
(https://github.com/nipreps/fmriprep/blob/master/.zenodo.json), which
will result in your being listed as an author
at the next release. Please add yourself as the next-to-last entry, just
above Russ.
A pull request is a conversation. We may ask you to make some changes
before accepting your PR,
and likewise, you should feel free to ask us any questions you have.
-->File tree
5 files changed
+31
-17
lines changed- fmriprep
- interfaces
- workflows/bold
5 files changed
+31
-17
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
71 | 76 | | |
72 | 77 | | |
73 | 78 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
981 | 981 | | |
982 | 982 | | |
983 | 983 | | |
984 | | - | |
| 984 | + | |
| 985 | + | |
| 986 | + | |
| 987 | + | |
985 | 988 | | |
986 | 989 | | |
987 | 990 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
110 | | - | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
111 | 114 | | |
112 | 115 | | |
113 | 116 | | |
| |||
122 | 125 | | |
123 | 126 | | |
124 | 127 | | |
125 | | - | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
126 | 132 | | |
127 | 133 | | |
128 | 134 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| |||
0 commit comments